Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support R1 reasoning text in model create result; enhance API docs #5262

Merged
merged 11 commits into from
Jan 30, 2025

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Jan 30, 2025

Resolves #5255

TODO: Partially address #5192, more work needed to incorporate the non-None content when tool calls is detected.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.39%. Comparing base (fff201f) to head (73a5d44).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5262       +/-   ##
===========================================
- Coverage   83.70%   66.39%   -17.32%     
===========================================
  Files          60      120       +60     
  Lines        2817     8843     +6026     
===========================================
+ Hits         2358     5871     +3513     
- Misses        459     2972     +2513     
Flag Coverage Δ
unittests 66.39% <100.00%> (-17.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@afourney afourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like what we discussed. Looking forward to using this.

@ekzhu ekzhu enabled auto-merge (squash) January 30, 2025 18:19
@ekzhu ekzhu disabled auto-merge January 30, 2025 18:24
@ekzhu ekzhu merged commit f656ff1 into main Jan 30, 2025
66 checks passed
@ekzhu ekzhu deleted the ekzhu-thought-field branch January 30, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateResult to include an optional field for reasoning token to support R1
3 participants