Added type hints existence validation to make error message when miss… #5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing more explicit
ekzhu
reviewed
Jan 27, 2025
| @@ -1,6 +1,7 @@ | |||
| import asyncio | |||
| import functools | |||
| import warnings | |||
| import typing | |||
There was a problem hiding this comment.
Can we use from typing import get_type_hints?
ekzhu
reviewed
Jan 27, 2025
| # Validate type hints exist | ||
| hints = typing.get_type_hints(func) | ||
| if not hints: | ||
| raise TypeError(f"Function '{func.__name__}' has no type hints. All parameters must be annotated.") |
There was a problem hiding this comment.
The issue you referenced, the function argument has type hint. Can this catch the same error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change: Added type hints existence validation to make error message when missing more explicit.
Why are these changes needed?
The FunctionTool class requires type hints on function parameters to generate proper schemas for input validation and LLM interaction. Previously, when type hints were missing, the error message was not explicit enough to help users understand the requirement. This change adds explicit validation to check for type hints existence and provides a clearer error message when they are missing.
I spent sometime trying to figure out the vagye error message, found another person reporting this issue: #5142
Related issue number
Not an issue, but a discussion here: #5142
Checks