-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use caching to run tests and report coverage #5086
Use caching to run tests and report coverage #5086
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5086 +/- ##
=======================================
Coverage 69.91% 69.91%
=======================================
Files 168 168
Lines 10698 10698
=======================================
Hits 7479 7479
Misses 3219 3219
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jackgerrits @ekzhu , I think we are running out of resources in the worker to run tests in parallel. The autogen-ext tests are failing with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Why are these changes needed?
Currently, unit tests are running twice, once in the test step and a second time in code coverage, duplicating resource usage and increasing CI time. This PR updates the build process to always generate the the coverage file during the initial testing and cache it in GitHub Actions artifactions. During the coverage step we just download the files to measure coverage.
Related issue number
Checks