Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent name termination #4123

Merged
merged 14 commits into from
Nov 23, 2024
Merged

Conversation

thainduy
Copy link
Contributor

Why are these changes needed?

Introduces the AgentNameTermination class, which is a termination condition for conversations based on last agent name

Related issue number

Checks

Sorry, something went wrong.

ThaiND and others added 2 commits November 10, 2024 12:53

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@thainduy
Copy link
Contributor Author

@microsoft-github-policy-service agree

- Rename class to `SourceMatchTermination`
@thainduy thainduy force-pushed the ext-AgentNameTermination branch from 738d02f to f3470bc Compare November 13, 2024 02:25
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this into autogen-agentchat, there is no external dependency.

@thainduy thainduy requested a review from ekzhu November 20, 2024 02:27
@thainduy
Copy link
Contributor Author

Let's move this into autogen-agentchat, there is no external dependency.

moved to autogen-agentchat, pls check again

ekzhu and others added 7 commits November 20, 2024 10:51
# Conflicts:
#	python/packages/autogen-agentchat/src/autogen_agentchat/task/__init__.py
#	python/packages/autogen-agentchat/src/autogen_agentchat/task/_terminations.py
#	python/packages/autogen-agentchat/tests/test_termination_condition.py
@ekzhu ekzhu merged commit 0b5eaf1 into microsoft:main Nov 23, 2024
41 checks passed
@thainduy thainduy deleted the ext-AgentNameTermination branch November 23, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants