AgentEval Offline Integration #2345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeibinLi
reviewed
Apr 10, 2024
BeibinLi
reviewed
Apr 10, 2024
BeibinLi
reviewed
Apr 10, 2024
BeibinLi
reviewed
Apr 10, 2024
BeibinLi
reviewed
Apr 10, 2024
BeibinLi
reviewed
Apr 10, 2024
BeibinLi
reviewed
Apr 10, 2024
sonichi
reviewed
Apr 11, 2024
sonichi
reviewed
May 2, 2024
|
|
||
|
|
||
| @pytest.mark.skipif( | ||
| skip_openai, |
There was a problem hiding this comment.
To run this test in CI, we need to (1) create a new PR from a branch in the upstream repo; (2) add a section in contrib-openai.yml to run the test.
There was a problem hiding this comment.
@sonichi can you clarify what you mean by (1)? is this a new PR entirely or just merging in changes from a different branch?
There was a problem hiding this comment.
A new PR with the same changes as in this PR.
jluey1
commented
May 3, 2024
|
|
||
|
|
||
| @pytest.mark.skipif( | ||
| skip_openai, |
There was a problem hiding this comment.
@sonichi can you clarify what you mean by (1)? is this a new PR entirely or just merging in changes from a different branch?
julianakiseleva
approved these changes
May 7, 2024
Co-authored-by: Wael Karkoub <[email protected]>
Co-authored-by: Wael Karkoub <[email protected]>
|
Closing in order to make a new PR from agenteval_integration into main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
See issue #2162
Checks