feat: Support R1 reasoning text in model create result; enhance API docs #5262
+536
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzhu
requested review from
jackgerrits,
victordibia,
afourney,
bassmang and
lokitoth
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5262 +/- ##
===========================================
- Coverage 83.70% 66.39% -17.32%
===========================================
Files 60 120 +60
Lines 2817 8843 +6026
===========================================
+ Hits 2358 5871 +3513
- Misses 459 2972 +2513
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
afourney
approved these changes
Jan 30, 2025
osdemah
reviewed
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5255
TODO: Partially address #5192, more work needed to incorporate the non-None content when tool calls is detected.