Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson5 refactor #94

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ShivamGoyal03
Copy link
Contributor

Updated Lesson 5 Agentic RAG with 2-3 different plugins, here, WeatherInfoPlugin to show different scenarios of using Semantic Kernel in RAG

Pending tasks

  • Autogen w ChromaDB is yet to be completed

@Copilot Copilot bot review requested due to automatic review settings March 10, 2025 17:56
Copy link

👋 Thanks for contributing @ShivamGoyal03! We will review the pull request and get back to you soon.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR refactors Lesson 5 Agentic RAG by integrating a new WeatherInfoPlugin and updating various documentation and code samples.

  • Revised wording in README files for clarity
  • Adjusted execution counts and minor code reorganizations in the notebooks
  • Added a unified RAG function that incorporates weather data alongside document retrieval

Reviewed Changes

File Description
02-explore-agentic-frameworks/README.md Updated phrasing for clarity in lesson objectives
00-course-setup/README.md Minor text adjustment from "code" to "course"
06-building-trustworthy-agents/README.md Corrected description text for the travel agent prompt
05-agentic-rag/code_samples/05-semantic-kernel-azuresearch.ipynb Updated execution counts and minor formatting fixes
05-agentic-rag/code_samples/05-autogen-azuresearch.ipynb Introduced unified RAG function with weather integration and updated cell executions

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

05-agentic-rag/code_samples/05-autogen-azuresearch.ipynb:309

  • Ensure that the 'documents' variable is properly defined in the current scope before using copy() to avoid a potential NameError at runtime.
combined_context = documents.copy()  # Start with travel documents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants