Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theming in spacing page #1639

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcelwgn
Copy link
Contributor

Description

Fixing text on spacing page being hard to read when using the theme switch button. This was caused because we didn't include SampleThemeListener and the default behavior of ItemsPages is to switch the theme of the entire page if none are used in a sample page.

Motivation and Context

Fixes #1637

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing Page → Incorrect Highlighting on Theme Toggle
1 participant