Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add union and intersection types to unions by type list id #54554

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add union and intersection types to unions by type list id #54554

wants to merge 1 commit into from
+103 −3

Conversation

weswigham
Copy link
Member

Rather than type id. This makes identical lists with differing alias symbols be recognized as equivalent (and therefore not cost anything to construct). This should be most notable with control flow, which often strips the alias symbol from a union in the process of stripping it apart and putting it back together.

Fixes #54146

@weswigham
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 6, 2023 •
edited
Loading

Heya @weswigham, I've started to run the perf test suite on this PR at 0406af1. You can monitor the build here.

Update: The results are in!

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 6, 2023
@typescript-bot
Copy link
Collaborator

@weswigham
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54554
Metric main 54554 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 366,165k (± 0.00%) 366,154k (± 0.01%) ~ 366,100k 366,220k p=0.471 n=6
Parse Time 3.40s (± 0.48%) 3.42s (± 0.82%) ~ 3.38s 3.44s p=0.415 n=6
Bind Time 1.11s (± 0.89%) 1.11s (± 0.73%) ~ 1.10s 1.12s p=0.383 n=6
Check Time 8.75s (± 0.29%) 8.76s (± 0.28%) ~ 8.73s 8.80s p=0.936 n=6
Emit Time 7.43s (± 0.18%) 7.41s (± 0.49%) ~ 7.37s 7.48s p=0.143 n=6
Total Time 20.70s (± 0.17%) 20.70s (± 0.30%) ~ 20.59s 20.78s p=0.747 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 192,096k (± 1.20%) 192,131k (± 1.20%) ~ 191,125k 196,822k p=0.575 n=6
Parse Time 1.51s (± 1.36%) 1.49s (± 1.17%) ~ 1.46s 1.51s p=0.118 n=6
Bind Time 0.77s (± 0.82%) 0.77s (± 0.72%) ~ 0.76s 0.77s p=0.201 n=6
Check Time 9.48s (± 0.50%) 9.46s (± 0.81%) ~ 9.36s 9.56s p=0.228 n=6
Emit Time 2.72s (± 1.77%) 2.75s (± 1.67%) ~ 2.68s 2.81s p=0.261 n=6
Total Time 14.48s (± 0.57%) 14.47s (± 0.65%) ~ 14.38s 14.62s p=0.630 n=6
Monaco - node (v18.10.0, x64)
Memory used 346,620k (± 0.01%) 346,619k (± 0.01%) ~ 346,567k 346,637k p=0.936 n=6
Parse Time 2.60s (± 1.32%) 2.59s (± 0.71%) ~ 2.57s 2.61s p=1.000 n=6
Bind Time 1.00s (± 0.54%) 1.00s (± 0.41%) ~ 1.00s 1.01s p=0.282 n=6
Check Time 7.13s (± 0.88%) 7.10s (± 0.37%) ~ 7.06s 7.13s p=0.228 n=6
Emit Time 4.26s (± 0.54%) 4.25s (± 0.91%) ~ 4.20s 4.28s p=0.686 n=6
Total Time 15.00s (± 0.41%) 14.93s (± 0.25%) ~ 14.89s 14.98s p=0.075 n=6
TFS - node (v18.10.0, x64)
Memory used 300,640k (± 0.01%) 300,615k (± 0.01%) ~ 300,583k 300,639k p=0.128 n=6
Parse Time 2.06s (± 1.02%) 2.06s (± 1.22%) ~ 2.03s 2.09s p=0.808 n=6
Bind Time 1.14s (± 0.66%) 1.13s (± 0.48%) ~ 1.13s 1.14s p=0.476 n=6
Check Time 6.61s (± 0.40%) 6.59s (± 0.30%) ~ 6.58s 6.63s p=0.154 n=6
Emit Time 3.85s (± 0.75%) 3.85s (± 0.80%) ~ 3.81s 3.90s p=0.870 n=6
Total Time 13.65s (± 0.53%) 13.64s (± 0.38%) ~ 13.58s 13.69s p=0.872 n=6
material-ui - node (v18.10.0, x64)
Memory used 481,759k (± 0.00%) 483,688k (± 0.01%) +1,929k (+ 0.40%) 483,602k 483,754k p=0.005 n=6
Parse Time 3.10s (± 0.53%) 3.10s (± 0.63%) ~ 3.07s 3.12s p=1.000 n=6
Bind Time 0.91s (± 0.89%) 0.91s (± 1.20%) ~ 0.90s 0.93s p=0.448 n=6
Check Time 16.75s (± 0.27%) 16.93s (± 0.69%) +0.19s (+ 1.12%) 16.81s 17.14s p=0.008 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.76s (± 0.24%) 20.95s (± 0.57%) +0.18s (+ 0.89%) 20.81s 21.14s p=0.013 n=6
xstate - node (v18.10.0, x64)
Memory used 563,162k (± 0.03%) 563,183k (± 0.02%) ~ 563,063k 563,384k p=0.936 n=6
Parse Time 3.85s (± 0.63%) 3.80s (± 0.39%) -0.04s (- 1.13%) 3.78s 3.82s p=0.030 n=6
Bind Time 1.63s (± 0.63%) 1.63s (± 0.46%) ~ 1.62s 1.64s p=0.437 n=6
Check Time 2.80s (± 0.58%) 2.81s (± 0.69%) ~ 2.78s 2.83s p=0.567 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.35s (± 0.30%) 8.33s (± 0.30%) ~ 8.30s 8.37s p=0.223 n=6
Angular - node (v16.17.1, x64)
Memory used 365,567k (± 0.01%) 365,546k (± 0.01%) ~ 365,453k 365,580k p=0.378 n=6
Parse Time 3.56s (± 0.49%) 3.57s (± 0.52%) ~ 3.54s 3.59s p=0.366 n=6
Bind Time 1.18s (± 0.64%) 1.18s (± 0.35%) ~ 1.18s 1.19s p=1.000 n=6
Check Time 9.58s (± 0.46%) 9.59s (± 0.50%) ~ 9.54s 9.66s p=0.466 n=6
Emit Time 7.94s (± 0.88%) 7.93s (± 0.70%) ~ 7.85s 8.00s p=0.936 n=6
Total Time 22.26s (± 0.56%) 22.27s (± 0.34%) ~ 22.15s 22.36s p=0.629 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,869k (± 0.02%) 193,495k (± 0.73%) +625k (+ 0.32%) 192,916k 196,362k p=0.020 n=6
Parse Time 1.60s (± 0.32%) 1.59s (± 1.32%) ~ 1.55s 1.61s p=0.794 n=6
Bind Time 0.83s (± 0.66%) 0.83s (± 0.62%) ~ 0.82s 0.83s p=0.640 n=6
Check Time 10.19s (± 0.88%) 10.17s (± 0.26%) ~ 10.12s 10.20s p=1.000 n=6
Emit Time 3.01s (± 1.00%) 3.01s (± 0.35%) ~ 2.99s 3.02s p=0.627 n=6
Total Time 15.62s (± 0.63%) 15.59s (± 0.17%) ~ 15.54s 15.61s p=0.688 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,889k (± 0.00%) 345,892k (± 0.00%) ~ 345,869k 345,905k p=0.226 n=6
Parse Time 2.73s (± 0.36%) 2.73s (± 0.19%) ~ 2.73s 2.74s p=0.348 n=6
Bind Time 1.08s (± 0.50%) 1.09s (± 0.50%) ~ 1.08s 1.09s p=1.000 n=6
Check Time 7.83s (± 0.91%) 7.86s (± 0.38%) ~ 7.82s 7.89s p=0.467 n=6
Emit Time 4.45s (± 0.48%) 4.47s (± 0.41%) ~ 4.45s 4.50s p=0.089 n=6
Total Time 16.08s (± 0.47%) 16.15s (± 0.29%) ~ 16.09s 16.22s p=0.146 n=6
TFS - node (v16.17.1, x64)
Memory used 299,959k (± 0.01%) 299,977k (± 0.01%) ~ 299,956k 299,992k p=0.173 n=6
Parse Time 2.16s (± 0.54%) 2.15s (± 0.82%) ~ 2.14s 2.19s p=0.404 n=6
Bind Time 1.23s (± 0.51%) 1.24s (± 1.18%) ~ 1.23s 1.27s p=0.081 n=6
Check Time 7.25s (± 0.68%) 7.25s (± 0.40%) ~ 7.21s 7.30s p=0.871 n=6
Emit Time 4.33s (± 0.84%) 4.35s (± 1.21%) ~ 4.30s 4.44s p=0.468 n=6
Total Time 14.97s (± 0.44%) 15.00s (± 0.59%) ~ 14.90s 15.15s p=0.630 n=6
material-ui - node (v16.17.1, x64)
Memory used 480,998k (± 0.01%) 482,955k (± 0.00%) +1,957k (+ 0.41%) 482,937k 482,979k p=0.005 n=6
Parse Time 3.24s (± 0.38%) 3.25s (± 0.43%) ~ 3.23s 3.27s p=0.564 n=6
Bind Time 0.94s (± 0.80%) 0.94s (± 0.43%) ~ 0.93s 0.94s p=0.389 n=6
Check Time 17.86s (± 0.45%) 18.04s (± 0.55%) +0.18s (+ 0.99%) 17.89s 18.17s p=0.016 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.05s (± 0.34%) 22.22s (± 0.47%) +0.17s (+ 0.79%) 22.07s 22.37s p=0.020 n=6
xstate - node (v16.17.1, x64)
Memory used 560,596k (± 0.02%) 560,658k (± 0.02%) ~ 560,493k 560,776k p=0.378 n=6
Parse Time 4.01s (± 0.77%) 4.00s (± 0.38%) ~ 3.97s 4.01s p=0.686 n=6
Bind Time 1.75s (± 0.67%) 1.76s (± 0.29%) +0.01s (+ 0.67%) 1.76s 1.77s p=0.039 n=6
Check Time 3.06s (± 0.43%) 3.07s (± 0.32%) ~ 3.06s 3.09s p=0.176 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.91s (± 0.37%) 8.92s (± 0.28%) ~ 8.89s 8.96s p=0.684 n=6
Angular - node (v14.21.3, x64)
Memory used 359,551k (± 0.00%) 359,546k (± 0.01%) ~ 359,499k 359,604k p=0.630 n=6
Parse Time 3.67s (± 0.64%) 3.65s (± 0.38%) ~ 3.63s 3.67s p=0.620 n=6
Bind Time 1.22s (± 0.33%) 1.22s (± 0.67%) ~ 1.21s 1.23s p=0.584 n=6
Check Time 10.01s (± 0.53%) 10.04s (± 0.26%) ~ 10.01s 10.09s p=0.164 n=6
Emit Time 8.38s (± 0.71%) 8.32s (± 0.78%) ~ 8.24s 8.43s p=0.127 n=6
Total Time 23.27s (± 0.48%) 23.25s (± 0.26%) ~ 23.18s 23.36s p=0.687 n=6
Compiler-Unions - node (v14.21.3, x64)
Memory used 188,302k (± 0.01%) 188,269k (± 0.02%) ~ 188,225k 188,312k p=0.229 n=6
Parse Time 1.62s (± 0.50%) 1.62s (± 1.27%) ~ 1.60s 1.66s p=0.677 n=6
Bind Time 0.84s (± 0.65%) 0.84s (± 0.48%) ~ 0.84s 0.85s p=0.282 n=6
Check Time 10.28s (± 0.52%) 10.31s (± 0.81%) ~ 10.21s 10.43s p=0.630 n=6
Emit Time 3.13s (± 0.42%) 3.13s (± 0.44%) ~ 3.10s 3.14s p=0.929 n=6
Total Time 15.87s (± 0.35%) 15.91s (± 0.64%) ~ 15.80s 16.06s p=0.521 n=6
Monaco - node (v14.21.3, x64)
Memory used 341,019k (± 0.01%) 341,020k (± 0.01%) ~ 340,954k 341,049k p=0.936 n=6
Parse Time 2.81s (± 0.74%) 2.81s (± 0.50%) ~ 2.79s 2.83s p=0.807 n=6
Bind Time 1.11s (± 0.89%) 1.11s (± 0.94%) ~ 1.10s 1.13s p=0.315 n=6
Check Time 8.18s (± 0.47%) 8.15s (± 0.43%) ~ 8.08s 8.17s p=0.114 n=6
Emit Time 4.69s (± 1.11%) 4.70s (± 0.94%) ~ 4.64s 4.75s p=0.748 n=6
Total Time 16.79s (± 0.48%) 16.77s (± 0.21%) ~ 16.74s 16.82s p=0.572 n=6
TFS - node (v14.21.3, x64)
Memory used 295,145k (± 0.00%) 295,141k (± 0.00%) ~ 295,134k 295,154k p=0.297 n=6
Parse Time 2.39s (± 0.78%) 2.40s (± 0.43%) ~ 2.38s 2.41s p=0.508 n=6
Bind Time 1.06s (± 0.00%) 1.06s (± 0.38%) ~ 1.06s 1.07s p=0.405 n=6
Check Time 7.60s (± 0.38%) 7.57s (± 0.50%) ~ 7.51s 7.61s p=0.089 n=6
Emit Time 4.30s (± 0.75%) 4.30s (± 0.28%) ~ 4.29s 4.32s p=0.746 n=6
Total Time 15.35s (± 0.30%) 15.33s (± 0.32%) ~ 15.29s 15.40s p=0.572 n=6
material-ui - node (v14.21.3, x64)
Memory used 476,578k (± 0.01%) 478,645k (± 0.00%) +2,067k (+ 0.43%) 478,613k 478,662k p=0.005 n=6
Parse Time 3.34s (± 0.48%) 3.33s (± 0.40%) ~ 3.31s 3.34s p=0.271 n=6
Bind Time 1.01s (± 0.81%) 1.00s (± 0.41%) ~ 1.00s 1.01s p=0.109 n=6
Check Time 18.74s (± 0.62%) 18.88s (± 0.16%) ~ 18.83s 18.91s p=0.065 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.08s (± 0.51%) 23.21s (± 0.09%) ~ 23.18s 23.24s p=0.065 n=6
xstate - node (v14.21.3, x64)
Memory used 549,678k (± 0.00%) 549,666k (± 0.00%) ~ 549,646k 549,683k p=0.261 n=6
Parse Time 4.23s (± 0.41%) 4.22s (± 0.46%) ~ 4.19s 4.24s p=0.332 n=6
Bind Time 1.67s (± 0.24%) 1.67s (± 0.38%) ~ 1.66s 1.68s p=0.673 n=6
Check Time 3.18s (± 0.96%) 3.18s (± 0.38%) ~ 3.16s 3.19s p=0.465 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.17s (± 0.37%) 9.15s (± 0.25%) ~ 9.13s 9.19s p=0.165 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.21.3, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.21.3, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.21.3, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.21.3, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.21.3, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.21.3, x64)
Benchmark Name Iterations
Current 54554 6
Baseline main 6

TSServer

Comparison Report - main..54554
Metric main 54554 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,540ms (± 0.52%) 2,538ms (± 0.38%) ~ 2,523ms 2,547ms p=1.000 n=6
Req 2 - geterr 5,543ms (± 0.39%) 5,533ms (± 0.59%) ~ 5,483ms 5,579ms p=0.521 n=6
Req 3 - references 340ms (± 1.14%) 338ms (± 1.13%) ~ 335ms 344ms p=0.569 n=6
Req 4 - navto 285ms (± 0.36%) 285ms (± 0.69%) ~ 284ms 289ms p=0.652 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 85ms (± 0.48%) 84ms (± 0.48%) -1ms (- 0.79%) 84ms 85ms p=0.034 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,656ms (± 0.85%) 2,651ms (± 0.96%) ~ 2,628ms 2,696ms p=0.471 n=6
Req 2 - geterr 4,295ms (± 0.33%) 4,260ms (± 1.87%) ~ 4,097ms 4,298ms p=0.377 n=6
Req 3 - references 347ms (± 0.54%) 348ms (± 1.00%) ~ 345ms 355ms p=0.413 n=6
Req 4 - navto 290ms (± 0.60%) 291ms (± 0.64%) ~ 289ms 294ms p=0.869 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 66ms (± 6.14%) 67ms (±10.00%) ~ 62ms 79ms p=0.933 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,088ms (± 0.48%) 3,082ms (± 0.66%) ~ 3,066ms 3,119ms p=0.422 n=6
Req 2 - geterr 1,575ms (± 1.82%) 1,553ms (± 0.55%) ~ 1,544ms 1,569ms p=0.173 n=6
Req 3 - references 114ms (± 1.82%) 113ms (± 0.49%) ~ 112ms 113ms p=0.100 n=6
Req 4 - navto 358ms (± 0.41%) 358ms (± 0.56%) ~ 357ms 362ms p=0.485 n=6
Req 5 - completionInfo count 2,864 (± 0.00%) 2,864 (± 0.00%) ~ 2,864 2,864 p=1.000 n=6
Req 5 - completionInfo 381ms (± 1.70%) 380ms (± 2.23%) ~ 368ms 392ms p=0.572 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,686ms (± 1.11%) 2,665ms (± 0.70%) ~ 2,651ms 2,694ms p=0.229 n=6
Req 2 - geterr 6,015ms (± 0.40%) 6,015ms (± 0.47%) ~ 5,973ms 6,059ms p=0.936 n=6
Req 3 - references 351ms (± 0.40%) 352ms (± 0.39%) ~ 351ms 354ms p=0.162 n=6
Req 4 - navto 290ms (± 1.33%) 286ms (± 1.49%) ~ 281ms 293ms p=0.104 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 92ms (± 2.32%) 93ms (± 0.96%) ~ 92ms 94ms p=0.363 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,843ms (± 0.51%) 2,838ms (± 0.73%) ~ 2,809ms 2,861ms p=0.810 n=6
Req 2 - geterr 4,650ms (± 0.35%) 4,653ms (± 0.22%) ~ 4,637ms 4,663ms p=0.378 n=6
Req 3 - references 364ms (± 0.90%) 364ms (± 0.40%) ~ 363ms 366ms p=1.000 n=6
Req 4 - navto 286ms (± 1.14%) 286ms (± 0.98%) ~ 282ms 288ms p=0.871 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 68ms (± 1.55%) 68ms (± 1.11%) ~ 67ms 69ms p=0.611 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,215ms (± 0.31%) 3,217ms (± 0.19%) ~ 3,208ms 3,226ms p=0.521 n=6
Req 2 - geterr 1,744ms (± 1.17%) 1,741ms (± 0.51%) ~ 1,731ms 1,755ms p=1.000 n=6
Req 3 - references 126ms (± 6.81%) 126ms (± 6.01%) ~ 121ms 141ms p=0.802 n=6
Req 4 - navto 341ms (± 0.52%) 340ms (± 0.43%) ~ 339ms 343ms p=0.869 n=6
Req 5 - completionInfo count 2,864 (± 0.00%) 2,864 (± 0.00%) ~ 2,864 2,864 p=1.000 n=6
Req 5 - completionInfo 411ms (± 1.49%) 407ms (± 1.64%) ~ 400ms 419ms p=0.295 n=6
Compiler-UnionsTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,791ms (± 0.55%) 2,785ms (± 0.62%) ~ 2,763ms 2,810ms p=0.470 n=6
Req 2 - geterr 6,205ms (± 0.40%) 6,220ms (± 1.31%) ~ 6,131ms 6,370ms p=1.000 n=6
Req 3 - references 364ms (± 1.45%) 364ms (± 1.01%) ~ 359ms 368ms p=0.936 n=6
Req 4 - navto 289ms (± 0.61%) 288ms (± 0.51%) ~ 286ms 290ms p=0.459 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 100ms (± 4.19%) 102ms (± 1.79%) ~ 99ms 104ms p=0.453 n=6
CompilerTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,975ms (± 0.60%) 2,966ms (± 0.55%) ~ 2,942ms 2,980ms p=0.575 n=6
Req 2 - geterr 4,523ms (± 0.31%) 4,553ms (± 0.58%) ~ 4,511ms 4,576ms p=0.078 n=6
Req 3 - references 374ms (± 1.12%) 372ms (± 0.63%) ~ 370ms 376ms p=0.686 n=6
Req 4 - navto 298ms (± 0.42%) 297ms (± 0.14%) ~ 297ms 298ms p=0.195 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 78ms (± 3.53%) 76ms (± 1.07%) ~ 75ms 77ms p=0.498 n=6
xstateTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 3,453ms (± 1.37%) 3,469ms (± 1.34%) ~ 3,386ms 3,525ms p=0.575 n=6
Req 2 - geterr 1,837ms (± 0.65%) 1,839ms (± 0.52%) ~ 1,823ms 1,849ms p=0.748 n=6
Req 3 - references 150ms (± 6.59%) 146ms (± 5.68%) ~ 138ms 160ms p=0.463 n=6
Req 4 - navto 396ms (± 1.08%) 402ms (± 1.44%) ~ 397ms 410ms p=0.166 n=6
Req 5 - completionInfo count 2,864 (± 0.00%) 2,864 (± 0.00%) ~ 2,864 2,864 p=1.000 n=6
Req 5 - completionInfo 430ms (± 3.32%) 448ms (± 2.28%) +18ms (+ 4.27%) 428ms 456ms p=0.030 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.21.3, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.21.3, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.21.3, x64)
Benchmark Name Iterations
Current 54554 6
Baseline main 6

Startup

Comparison Report - main..54554
Metric main 54554 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.16ms (± 0.19%) 141.53ms (± 0.21%) -0.63ms (- 0.44%) 140.61ms 145.72ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 220.82ms (± 0.19%) 220.68ms (± 0.22%) -0.14ms (- 0.06%) 219.43ms 226.81ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 222.46ms (± 0.19%) 222.16ms (± 0.25%) -0.30ms (- 0.13%) 220.87ms 227.79ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 204.45ms (± 0.24%) 204.01ms (± 0.21%) -0.44ms (- 0.22%) 202.87ms 209.56ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 54554 6
Baseline main 6

Developer Information:

Download Benchmark

@sandersn
Copy link
Member

sandersn commented Apr 1, 2025

Does this change make sense if Strada adopts the same type ordering scheme as Corsa? If not, should we close this PR?

@jakebailey
Copy link
Member

I think #61399 would be the equivalent for that if we do take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@weswigham weswigham

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type alias preserving logic defeats complexity reduction mechanisms
4 participants
@weswigham @typescript-bot @sandersn @jakebailey