Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix electron app path #639

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Fix electron app path #639

merged 6 commits into from
Jan 30, 2025
+14 −11

Conversation

curtisman
Copy link
Member

@curtisman curtisman commented Jan 30, 2025 •
edited
Loading

  • It doesn't like the trailing path separator.
  • Add check in simple smoke test to make sure we catch the load error in the future by checking the URL that is loaded.
  • Add smoke test to exercise startShell which the nightly shell test depends on.

@curtisman curtisman added this pull request to the merge queue Jan 30, 2025
Merged via the queue into microsoft:main with commit b7aacdd Jan 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@curtisman