Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra-BuildScript] Add PowerShell Script to Enforce Shared Common.Dotnet.CsWinRT.props in all CSharp Projects under Src Sub-Folder #37811

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jamrobot
Copy link
Contributor

@jamrobot jamrobot commented Mar 7, 2025

Summary of the Pull Request

  • Add PS Script to validate all CSharp projects properly import Common.Dotnet.CsWinRT.props
  • Enable this PS script in CI Pipeline
  • Update Fuzz-Project accordingly

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@jamrobot jamrobot requested a review from a team as a code owner March 7, 2025 02:30
@jamrobot jamrobot requested a review from Copilot March 7, 2025 02:31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds a PowerShell script to enforce that all CSharp projects under the src sub-folder import the shared Common.Dotnet.CsWinRT.props file and integrates this check into the CI pipeline.

  • A new CI step has been added to execute verifyCommonProps.ps1 with the source directory set to the src folder.
  • The build pipeline configuration file has been updated to include this audit step.

Reviewed Changes

File Description
.pipelines/v2/templates/job-build-project.yml Added a step to run a PowerShell script that verifies the inclusion of the common props.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants