Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT Run] Image cache corrupt #16625

Closed
1 task
htcfreek opened this issue Feb 28, 2022 · 11 comments
Closed
1 task

[PT Run] Image cache corrupt #16625

htcfreek opened this issue Feb 28, 2022 · 11 comments
Labels
Issue-Bug Something isn't working Priority-2 Bug that is medium priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Can't Repro Couldn't reproduce the issue on the most recent code path Severity-Regression This was working in a previous release

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Feb 28, 2022 •
edited
Loading

Microsoft PowerToys version

RC v0.56.0

Running as admin

  • Yes

Area(s) with issue?

PowerToys Run

Steps to reproduce

Some of the last changes corrupted image cache of PT Run. Icons shown incorrectly.
Maybe after a crash, but I am not sure. Deleting image cache file fixes the bug.

✔️ Expected Behavior

Correct image for each entry.

❌ Actual Behavior

Incorrect images.

Other Software

No response

Screenshots

Expected Actual
image image
image image
@htcfreek htcfreek added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Product-PowerToys Run Improved app launch PT Run (Win+R) Window Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels Feb 28, 2022
@htcfreek
Copy link
Collaborator Author

@jaimecbernardo , @stefansjfw , @crutkas , @TobiasSekan
I think this is release blocking. We should fix it before releasing v0.56.x !

@htcfreek htcfreek added Severity-Regression This was working in a previous release Needs-Team-Response An issue author responded so the team needs to follow up labels Feb 28, 2022
@htcfreek
Copy link
Collaborator Author

@stefansjfw
Seems to happen sometimes after crash from #16624.

@htcfreek
Copy link
Collaborator Author

@stefansjfw

Seems to happen sometimes after crash from #16624.

Regardless of the fact above we should prevent a corrupt image cache or whatever is causing the invalid images.

@jaimecbernardo
Copy link
Collaborator

This looks like it's not a regression though. While it's good to fix it, I don't think it's blocking release.

@htcfreek
Copy link
Collaborator Author

This looks like it's not a regression though. While it's good to fix it, I don't think it's blocking release.

I will update the prio to 2 and update the lable.

@htcfreek htcfreek changed the title IMPORTANT [PT Run] Image cache corrupt [PT Run] Image cache corrupt Feb 28, 2022
@htcfreek htcfreek added Priority-2 Bug that is medium priority and removed Priority-0 Bugs that we consider release-blocking/recall-class (P0) Needs-Team-Response An issue author responded so the team needs to follow up labels Feb 28, 2022
@htcfreek htcfreek mentioned this issue Jul 2, 2022
Closed
1 task
@htcfreek htcfreek mentioned this issue Jun 15, 2023
Merged
11 tasks
@jaimecbernardo jaimecbernardo removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jun 15, 2023
@stefansjfw
Copy link
Collaborator

@htcfreek does this still happen? /needinfo

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 26, 2024
@htcfreek
Copy link
Collaborator Author

Not sure. Hard to reproduce and debug. let's close.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Team-Response An issue author responded so the team needs to follow up label Jan 26, 2024
@stefansjfw
Copy link
Collaborator

Not sure. Hard to reproduce and debug. let's close.

ok. Just reopen it if it happens again. Thanks!

@htcfreek htcfreek reopened this Feb 7, 2024
@htcfreek htcfreek mentioned this issue Feb 7, 2024
Closed
@htcfreek
Copy link
Collaborator Author

htcfreek commented Feb 7, 2024

@stefansjfw
We have a report for v0.78.0 so I reopened the issue.

@cinnamon-msft
Copy link
Collaborator

Are you still experiencing this issue? /needinfo

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Mar 7, 2025
@htcfreek htcfreek added Resolution-Can't Repro Couldn't reproduce the issue on the most recent code path and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 7, 2025
@htcfreek
Copy link
Collaborator Author

htcfreek commented Mar 7, 2025

No. Not happened anymore.

@htcfreek htcfreek closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug Something isn't working Priority-2 Bug that is medium priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Can't Repro Couldn't reproduce the issue on the most recent code path Severity-Regression This was working in a previous release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jaimecbernardo @cinnamon-msft @stefansjfw @htcfreek