This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 133
avoid using dmidecode #908
Open
jasonwbarnett
wants to merge
1
commit into
microsoft:master
Choose a base branch
from
jasonwbarnett:jwb/do-not-use-dmidecode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
avoid using dmidecode #908
jasonwbarnett
wants to merge
1
commit into
microsoft:master
from
jasonwbarnett:jwb/do-not-use-dmidecode
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jasonwbarnett please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
d3ffe95
to
9043311
Compare
I didn't see any reason to depend on root privileges for dmidecode when you can just fetch the data directly as an unprivileged user
9043311
to
2d99d94
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see any reason to depend on root privileges for dmidecode when you can just fetch the information directly as an unprivileged user. This is one step towards me updating this the Hybrid Worker doesn't need to run as root.