Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more object path tests #1122

Merged
merged 3 commits into from
Jun 19, 2022
Merged

Added more object path tests #1122

merged 3 commits into from
Jun 19, 2022

Conversation

ArmaanMcleod
Copy link
Contributor

@ArmaanMcleod ArmaanMcleod commented Jun 18, 2022 •
edited
Loading

PR Summary

Related to #1110

Added more object path tests for current ref comparisons with no dot selector comparisons.

Alot of the other test paths seemed covered already, so not much to add here 🙂. Will add more in the future if I find any.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Code changes
    • Have unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@ArmaanMcleod ArmaanMcleod requested a review from a team as a code owner June 18, 2022 16:34
BernieWhite
BernieWhite approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArmaanMcleod Nice. All good to merge.

@ArmaanMcleod ArmaanMcleod merged commit b2b6ffb into microsoft:main Jun 19, 2022
@ArmaanMcleod ArmaanMcleod deleted the object-path-tests branch June 19, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernieWhite BernieWhite BernieWhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArmaanMcleod @BernieWhite