Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate property UnEvaluatedProperties #2268

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

Poltuu
Copy link
Contributor

@Poltuu Poltuu commented Mar 17, 2025

IOpenApiSchema interface already contains a UnevaluatedProperties property (different case).

@Poltuu
Copy link
Contributor Author

Poltuu commented Mar 17, 2025

@microsoft-github-policy-service agree company="Lucca"

@MaggieKimani1
Copy link
Contributor

Thank you for pointing this out and for the contribution!

@MaggieKimani1 MaggieKimani1 enabled auto-merge March 18, 2025 13:03
@MaggieKimani1 MaggieKimani1 merged commit 975ab4f into microsoft:main Mar 18, 2025
7 of 8 checks passed
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was missed.

public bool UnEvaluatedProperties { get; set; }

@Poltuu would you mind following up with another PR please?

@MaggieKimani1 when you merge community contributions, squash merge them and make sure the merge message contains conventional commits to trigger releases and update the changelog in the future.

@Poltuu
Copy link
Contributor Author

Poltuu commented Mar 18, 2025

but of course #2273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants