Add JSON schema support #1766
Merged
Add JSON schema support #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieKimani1
requested review from
irvinesunday,
darrelmiller,
zengin,
coseguera,
millicentachieng and
andrueastman
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…rray and assign it to the type property
|
| /// Unlike JSON Schema, the value MUST conform to the defined type for the Schema Object defined at the same level. | ||
| /// For example, if type is string, then default can be "foo" but cannot be 1. | ||
| /// </summary> | ||
| public OpenApiAny Default { get; set; } |
There was a problem hiding this comment.
Suggest using JsonNode here unless we need to use OpenApiAny. If we do, then let's also change enum.
| /// <summary> | ||
| /// Allows sending a null value for the defined schema. Default value is false. | ||
| /// </summary> | ||
| public bool Nullable { get; set; } |
There was a problem hiding this comment.
Nullable should be removed and represented as a member of the type array.
| /// <summary> | ||
| /// Indicates object is a placeholder reference to an actual object and does not contain valid data. | ||
| /// </summary> | ||
| public bool UnresolvedReference { get; set; } |
darrelmiller
approved these changes
Aug 20, 2024
|
Resolving these comments in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes #1733, #1763, #1764, #1765