Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnnxMatMul4Quantizer: Only support ort 1.18+, clean up logic #1642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jambayk
Copy link
Contributor

@jambayk jambayk commented Feb 22, 2025

Describe your changes

  • Only support onnxruntime 1.19+ so that we don't have to maintain conditional logic for older versions.
  • Simplify the config parameter descriptions. Just point to the ort tool file since it's hard to maintain the long descriptions that might become outdated.
  • Unify the shared parameters between the pass config params and the woq_config params. Otherwise, there might be unexpected behavior if the values don't match.
  • Introduce the tool options from newer versions of ort.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant