Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving objectives issue introduced with introduction of pass search #1585

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shaahji
Copy link
Contributor

@shaahji shaahji commented Jan 29, 2025

Resolving objectives issue introduced with introduction of pass search

Olive allows multiple passes under the "passes" key in config where each entry can have dictate its own evaluator config i.e. the evaluation config to use for that specific pass. However, with pass search, this becomes an issue because each pass within the group can dictate conflicting objectives and goals. Circumventing the issue by collecting all the objectives across the group with the last one in the list winning if named the same. Also, handle the case where not all objectives are generated as part of the
post evaluation signal.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

Reimplement search logic to include passes in search space.
Olive allows multiple passes under the "passes" key in config where each
entry can have dictate its own evaluator config i.e. the evaluation config
to use for that specific pass. However, with pass search, this becomes an
issue because each pass within the group can dictate conflicting objectives
and goals. Circumventing the issue by collecting all the objectives across
the group with the last one in the list winning if named the same.
Also, handle the case where not all objectives are generated as part of the
post evaluation signal.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant