Add DoRA pass #1579
Open
Add DoRA pass #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyu-work
force-pushed
the
xiaoyu/dora
branch
from
18d0645 to
64c66f9
Compare
devang-ml
reviewed
Jan 30, 2025
| @classmethod | ||
| def _default_config(cls, accelerator_spec: AcceleratorSpec) -> Dict[str, PassConfigParam]: | ||
| config = { | ||
| "ephemeral_gpu_offload": PassConfigParam( |
There was a problem hiding this comment.
Can this be used with LoRA also?
There was a problem hiding this comment.
I'm not sure, but from Huggingface documentation, this option is only used for Dora, so I didn't add this for Lora.
devang-ml
reviewed
Jan 30, 2025
| return config | ||
|
|
||
| def _run_for_config(self, model: HfModelHandler, config: Dict[str, Any], output_model_path: str) -> HfModelHandler: | ||
| # convert config to pass config class |
There was a problem hiding this comment.
This is identical as LoRA pass except the use_dora flag on enable_lora().
How could we avoid code duplication? The comments in LoRA's _run_for_config() has additional details that could be useful here also.
There was a problem hiding this comment.
That's true. I'm working on LoHa and LoKr also. Let me revisit this when adding those 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review
lintrunner -a(Optional) Issue link