Implement pass search #1562

shaahji · 2025-01-21T19:35:08Z

Implement pass search

Reimplement search logic to include passes in search space.

Checklist before requesting a review

Add unit tests for this change.
Make sure all tests can pass.
Update documents if necessary.
Lint and apply fixes to your code by running lintrunner -a
Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

review-notebook-app · 2025-01-21T19:35:14Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

test/unit_test/search/test_search_strategy.py

examples/mobilenet/prepare_config.py

olive/engine/engine.py

olive/search/samplers/__init__.py

olive/search/search_point.py

olive/search/search_strategy.py

olive/workflows/run/config.py

test/unit_test/search/test_search_results.py

test/unit_test/search/test_search_strategy.py

olive/search/search_parameter.py

olive/search/search_results.py

olive/search/search_strategy.py

examples/test/local/test_bert_cuda_gpu.py

xiaoyu-work · 2025-01-23T00:09:48Z

Can you also update documents related to your changes?

examples/bert/user_script.py

test/unit_test/search/test_search_strategy.py

shaahji · 2025-01-23T10:36:25Z

Can you also update documents related to your changes?

Done!

examples/__init__.py

examples/bert/bert.py

examples/llama2/llama2.py

examples/phi2/phi2.py

examples/phi3/phi3.py

examples/stable_diffusion/sd_utils/ort.py

olive/search/samplers/optuna_sampler.py

olive/search/search_strategy.py

olive/search/samplers/optuna_sampler.py

olive/search/samplers/search_sampler.py

olive/search/search_space.py

examples/stable_diffusion/sd_utils/ort.py

examples/stable_diffusion/stable_diffusion.py

.lintrunner.toml

docs/architecture.md

docs/source/how-to/configure-workflows/auto-opt.md

olive/search/search_space.py

xiaoyu-work · 2025-01-30T00:28:21Z

Without pass flow, how can we handle the pass search? Like pass: [[A,C],[B,C]]

shaahji · 2025-01-30T21:01:50Z

Without pass flow, how can we handle the pass search? Like pass: [[A,C],[B,C]]

Pass flows allowed for explicit order of passes to search over. This is replaced with a more generic version of pass search which takes both passes and individual pass parameters into account when building the search space. In the process, what is lost if the ability to use a single Olive config to make multiple workflows, like the example you presented in your question. That specific use case was more a side-effect of the pass flows implementation rather than by design.

* Relax version of bitsandbytes * Add triton to requirements * Few fixes for using newer version of torch

Reimplement search logic to include passes in search space.

shaahji mentioned this pull request Jan 21, 2025

Validate pass config before instantiating the pass #1553

Merged

6 tasks

github-advanced-security bot found potential problems Jan 21, 2025

View reviewed changes

test/unit_test/search/test_search_strategy.py Fixed Show resolved Hide resolved

github-advanced-security bot found potential problems Jan 21, 2025

View reviewed changes

shaahji force-pushed the shaahji/pass_search branch 3 times, most recently from 64d4138 to 534a692 Compare January 21, 2025 22:47

xiaoyu-work reviewed Jan 22, 2025

View reviewed changes

shaahji force-pushed the shaahji/pass_search branch 2 times, most recently from 3e6fbfd to 457d3b7 Compare January 23, 2025 09:52

github-advanced-security bot found potential problems Jan 23, 2025

View reviewed changes

examples/bert/user_script.py Fixed Show fixed Hide fixed

examples/bert/user_script.py Fixed Show fixed Hide fixed

examples/bert/user_script.py Fixed Show fixed Hide fixed

test/unit_test/search/test_search_strategy.py Fixed Show fixed Hide fixed

shaahji force-pushed the shaahji/pass_search branch 3 times, most recently from 58fa43e to d63c35a Compare January 23, 2025 10:31