Improve InMemoryProvider getRange function from O(N^2) to O(N) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastay
requested changes
Sep 5, 2024
|
Can you also bump the patch version in the package.json |
|
@microsoft-github-policy-service agree company="Microsoft" |
done |
eliranek1
approved these changes
Sep 9, 2024
thomastay
approved these changes
Sep 9, 2024
M1Les
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in the getRange function we're doing a O(N^2) operation when constructing the results array. This time complexity arises because of doing a concat of 2 arrays instead of doing push operations on a single array.