Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows fluent-bit feature to use resource optimization flag #1316

Closed

Conversation

wanlonghenry
Copy link
Contributor

@wanlonghenry wanlonghenry commented Sep 12, 2024

Fix windows fluent-bit feature to use resource optimization flag

issue 1: chart values for AZMON_WINDOWS_FLUENT_BIT_DISABLED was removed from rs pod

issue 2: as the AZMON_WINDOWS_FLUENT_BIT_DISABLED was set for windows, this value is always trues in win

@wanlonghenry wanlonghenry requested a review from a team as a code owner September 12, 2024 19:28
if [ "${AZMON_WINDOWS_FLUENT_BIT_DISABLED}" == "true" ] || [ -z "${AZMON_WINDOWS_FLUENT_BIT_DISABLED}" ] || [ "${USING_AAD_MSI_AUTH}" != "true" ] || [ "${RS_GENEVA_LOGS_INTEGRATION}" == "true" ]; then
if [ -e "/etc/config/kube.conf" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check - [ "${RS_GENEVA_LOGS_INTEGRATION}" == "true" ]; needs to be removed for cosmic to get the metrics collected through Geneva. let me test this change quickly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch [longw/win-ama-resource-optimization-flag-cosmic-geneva]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants