Fix windows fluent-bit feature to use resource optimization flag #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganga1980
reviewed
Sep 12, 2024
ganga1980
reviewed
Sep 12, 2024
ganga1980
reviewed
Sep 12, 2024
| if [ "${AZMON_WINDOWS_FLUENT_BIT_DISABLED}" == "true" ] || [ -z "${AZMON_WINDOWS_FLUENT_BIT_DISABLED}" ] || [ "${USING_AAD_MSI_AUTH}" != "true" ] || [ "${RS_GENEVA_LOGS_INTEGRATION}" == "true" ]; then | ||
| if [ -e "/etc/config/kube.conf" ]; then |
There was a problem hiding this comment.
This check - [ "${RS_GENEVA_LOGS_INTEGRATION}" == "true" ]; needs to be removed for cosmic to get the metrics collected through Geneva. let me test this change quickly.
There was a problem hiding this comment.
branch [longw/win-ama-resource-optimization-flag-cosmic-geneva]
ganga1980
reviewed
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix windows fluent-bit feature to use resource optimization flag
issue 1: chart values for AZMON_WINDOWS_FLUENT_BIT_DISABLED was removed from rs pod
issue 2: as the AZMON_WINDOWS_FLUENT_BIT_DISABLED was set for windows, this value is always trues in win