Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for mcr path in mooncake cloud #1132

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

wanlonghenry
Copy link
Contributor

Fix bug for mcr path in mooncake cloud, remove the image path overwrite of mcr.azk8s.cn.

@wanlonghenry wanlonghenry requested a review from a team as a code owner December 7, 2023 22:58
Copy link
Contributor

@pfrcks pfrcks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who controls the redirection? will the redirection always happen in mc?

@wanlonghenry
Copy link
Contributor Author

who controls the redirection? will the redirection always happen in mc?

yes mcr.azk8s.zn is a mirror of mcr.microsoft.com and I think the mcr controls redirect in Mooncake as arc, aks pods are also using the mcr.microsoft.com

@wanlonghenry wanlonghenry merged commit e6f6bea into ci_prod Dec 8, 2023
15 checks passed
wanlonghenry added a commit that referenced this pull request Dec 11, 2023
* fix bug for mcr path in mooncake region

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants