flex_cblas_sdot and flex_cblas_snrm2 #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMovaghati
reviewed
Nov 8, 2023
There was a problem hiding this comment.
we should make sure their test projects are running and passing at each step, otherwise it would be hard to figure out which part is causing trouble. (I mean the validating the output values)
maybe we can find one of their tests that hits all these functions and use that one (maybe test_insert_delete_consolidate)?
| #include "filter_utils.h" | ||
| #include "utils.h" | ||
| #include "../../src/math_utils.cpp" |
There was a problem hiding this comment.
can you include #include "math_utils.h"?
There was a problem hiding this comment.
No, it doesn't know the path.
| using Flex_INT = MKL_INT; | ||
| #endif | ||
|
|
||
| float flex_cblas_sdot(const int64_t N, const float *X, const int incX, const float *Y, const int incY) noexcept |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new preprocessor flag, moved 2 of MKL methods into wrapper methods.