Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shellcheck warnings and errors only #6784

Merged

Conversation

achamayou
Copy link
Member

No description provided.

@maxtropets
Copy link
Collaborator

I personally prefer to see warnings and making a decision of whether to disable or fix particular things.

For bash checks, however, I don't think I care enough to insist on that, just sharing my thoughts here.

@achamayou
Copy link
Member Author

@maxtropets yes, this show errors and warnings still, but disables "info" and "style": https://github.com/koalaman/shellcheck/blob/d3001f337aa3f7653a621b302261f4eac01890d0/shellcheck.1.md?plain=1#L108

Those are quite opinionated and not terribly helpful, if you look at the ones we have so far. SC2230 for example recommends a substantially worse alternative to which, to avoid taking a non-POSIX dependency. This is actively counter-productive for our intended usage, and even arguably in general in 2025.

@achamayou achamayou added this pull request to the merge queue Jan 29, 2025
Merged via the queue into microsoft:main with commit 8ab87d0 Jan 29, 2025
18 checks passed
@achamayou achamayou deleted the shellcheck_warnings_and_above_only branch January 29, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants