Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove now-unused code specific to a deprecated platform #6781

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Remove now-unused code specific to a deprecated platform #6781

merged 3 commits into from
Jan 27, 2025

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Jan 27, 2025 •
edited
Loading

Completes some of the removal of INSIDE_ENCLAVE, highlighted in #6413. At least two uses seem worth keeping for now:

  1. Differentiating enclave/host logging is useful until the ringbuffer is removed
  2. (mis)-using INSIDE_ENCLAVE as a way to detect that some debug features should not be enabled

@achamayou achamayou requested a review from a team as a code owner January 27, 2025 14:53
@achamayou achamayou added this pull request to the merge queue Jan 27, 2025
Merged via the queue into microsoft:main with commit 7fa2b13 Jan 27, 2025
18 checks passed
@achamayou achamayou deleted the remove_dead_sgx_code branch January 27, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyashton eddyashton eddyashton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achamayou @eddyashton