Fix Raft scenarios with dependency on dispatch order #6748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted here:
#6588 (comment)
These 2 raft scenarios (
reconfig_01_23
andreconfig_01_el0_23
) are failing when built withlibstdc++
(rather thanlibcxx
), as thedispatch_all
steps produce a different iteration order. In situations where multiple nodes could become primary, this results in a different node succeeding than was asserted.I believe the correct fix is to remove the assertion, we can only say that a node has become primary, and back that up with stronger assertions later to ensure both nodes have fully caught up with commit progress.
Closes #6718