Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Raft scenarios with dependency on dispatch order #6748

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

eddyashton
Copy link
Member

@eddyashton eddyashton commented Jan 9, 2025

As noted here:

#6588 (comment)

These 2 raft scenarios (reconfig_01_23 and reconfig_01_el0_23) are failing when built with libstdc++ (rather than libcxx), as the dispatch_all steps produce a different iteration order. In situations where multiple nodes could become primary, this results in a different node succeeding than was asserted.

I believe the correct fix is to remove the assertion, we can only say that a node has become primary, and back that up with stronger assertions later to ensure both nodes have fully caught up with commit progress.

Closes #6718

@eddyashton eddyashton requested a review from a team as a code owner January 9, 2025 11:53
Copy link
Collaborator

@maxtropets maxtropets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddyashton Could you please also remove raft_scenario filter from ci.yml for Azure Linux test run?

@achamayou achamayou enabled auto-merge January 9, 2025 13:18
@achamayou achamayou added this pull request to the merge queue Jan 9, 2025
Merged via the queue into microsoft:main with commit c115b6d Jan 9, 2025
13 checks passed
@achamayou achamayou deleted the raft_scenarios_overspecified branch January 9, 2025 14:40
@achamayou achamayou added this to the Azure Linux Support milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix raft_scenario test on Azure Linux
3 participants