Remove elements from map outside of loop. (#4682)

.devcontainer/devcontainer.json

@@ -19,5 +19,6 @@
     "ghcr.io/devcontainers/features/docker-from-docker:1": {
       "version": "latest"
     }
-  }
+  },
+  "postCreateCommand": "DEBIAN_FRONTEND=noninteractive apt-get update && apt-get install gdb -y"
 }

.vscode/launch.json

@@ -124,6 +124,25 @@
       "postRunCommands": [
         "process handle --pass true --stop false --notify true SIGILL"
       ]
+    },
+    {
+      "name": "Debug Raft Test Scenarios (gdb)",
+      "type": "cppdbg",
+      "request": "launch",
+      "program": "${workspaceFolder}/build/raft_driver",
+      "args": ["${file}"],
+      "stopAtEntry": false,
+      "cwd": "${workspaceFolder}/tests/raft_scenarios/",
+      "environment": [],
+      "externalConsole": false,
+      "MIMode": "gdb",
+      "setupCommands": [
+        {
+          "description": "Enable pretty-printing for gdb",
+          "text": "-enable-pretty-printing",
+          "ignoreFailures": true
+        }
+      ]
     }
   ]
 }

src/consensus/aft/test/logging_stub.h

@@ -294,16 +294,21 @@ namespace aft
     {
       auto configuration = consensus->get_latest_configuration_unsafe();
       std::unordered_set<ccf::NodeId> retired_nodes;
+      std::list<Configuration::Nodes::const_iterator> itrs;
 
       // Remove and track retired nodes
       for (auto it = configuration.begin(); it != configuration.end(); ++it)
       {
         if (new_configuration.find(it->first) == new_configuration.end())
         {
           retired_nodes.emplace(it->first);
-          it = configuration.erase(it);
+          itrs.push_back(it);
         }
       }
+      for (auto it : itrs)
+      {
+        configuration.erase(it);
+      }
 
       // Add new node to configuration
       for (const auto& [node_id, _] : new_configuration)