Skip to content

Commit

Permalink
Ensure the right version of libstdc++(11) is installed (#6788)
Browse files Browse the repository at this point in the history
  • Loading branch information
achamayou authored Jan 30, 2025
1 parent a092d26 commit a661ea2
Show file tree
Hide file tree
Showing 7 changed files with 26 additions and 6 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres Fto [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [6.0.0-dev14]

[6.0.0-dev14]: https://github.com/microsoft/CCF/releases/tag/6.0.0-dev14

### Fixed

- All containers now include the correct version of libstdc++/libstdc++-dev, and the Debian package captures the runtime requirement as well.

## [6.0.0-dev13]

[6.0.0-dev13]: https://github.com/microsoft/CCF/releases/tag/6.0.0-dev13
Expand Down
2 changes: 1 addition & 1 deletion cmake/cpack_settings.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ message(STATUS "Debian package version: ${CPACK_DEBIAN_PACKAGE_VERSION}")
# 1.1.1f, which corresponds to the OpenSSL 1.1.1t release (latest security
# patches).
set(CCF_DEB_BASE_DEPENDENCIES
"libuv1 (>= 1.34.2);openssl (>=1.1.1f);libnghttp2-14 (>=1.40.0);curl (>=7.68.0)"
"libuv1 (>= 1.34.2);openssl (>=1.1.1f);libnghttp2-14 (>=1.40.0);curl (>=7.68.0);libstdc++6 (>=11.0.0)"
)
set(CCF_DEB_DEPENDENCIES ${CCF_DEB_BASE_DEPENDENCIES})

Expand Down
7 changes: 7 additions & 0 deletions getting_started/setup_vm/roles/ccf_build/tasks/install.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
- name: Include vars for Clang
include_vars: "clang{{ clang_version }}.yml"

- name: Add stdcxx APT repository
apt_repository:
repo: "ppa:ubuntu-toolchain-r/test"
state: present
update_cache: yes
become: true

- name: Install debs
apt:
name: "{{ debs }}"
Expand Down
3 changes: 1 addition & 2 deletions getting_started/setup_vm/roles/ccf_build/vars/clang15.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ debs:
- apt-transport-https
- ninja-build
- libuv1-dev
- libc++-{{ clang_ver }}-dev
- libc++abi-{{ clang_ver }}-dev
- libstdc++-11-dev
- python3.8-dev
- python3.8-venv
- llvm-{{ clang_ver }}
Expand Down
7 changes: 7 additions & 0 deletions getting_started/setup_vm/roles/ccf_run/tasks/install.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
- name: Include vars for Clang
include_vars: "clang{{ clang_version }}.yml"

- name: Add stdcxx APT repository
apt_repository:
repo: "ppa:ubuntu-toolchain-r/test"
state: present
update_cache: yes
become: true

- name: Install debs
apt:
name: "{{ debs }}"
Expand Down
3 changes: 1 addition & 2 deletions getting_started/setup_vm/roles/ccf_run/vars/clang15.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
workspace: "/tmp/"
debs:
- libc++abi1-15
- libc++1-15
- libstdc++6
- libuv1
- libnghttp2-14
2 changes: 1 addition & 1 deletion python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "ccf"
version = "6.0.0-dev13"
version = "6.0.0-dev14"
authors = [
{ name="CCF Team", email="[email protected]" },
]
Expand Down

0 comments on commit a661ea2

Please sign in to comment.