js_v8 removal (#4368)

microsoft · Oct 18, 2022 · 3f8a65b · 3f8a65b
1 parent 53aee8d
commit 3f8a65b
Show file tree

Hide file tree

Showing 58 changed files with 6 additions and 7,010 deletions.
diff --git a/.daily_canary b/.daily_canary
@@ -1,4 +1,4 @@
    ___     ___
-  (- -)   (O o)
+  (- -)   (x x)
  (  V  ) (  V  )
 /--x-m- /--m-m-
diff --git a/.ycm_extra_conf.py b/.ycm_extra_conf.py
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -636,18 +636,6 @@ if(BUILD_TESTS)
       # large JS applications may trigger leadership changes
   )
 
-  if(ENABLE_V8)
-    add_e2e_test(
-      NAME modules_v8_test
-      PYTHON_SCRIPT ${CMAKE_SOURCE_DIR}/tests/js-modules/modules.py
-      CONSENSUS cft
-      ADDITIONAL_ARGS
-        --package libjs_v8 --election-timeout-ms 10000 # Larger election timeout
-                                                       # as recording
-        # large JS applications may trigger leadership changes
-    )
-  endif()
-
   add_e2e_test(
     NAME auth
     PYTHON_SCRIPT
@@ -657,17 +645,6 @@ if(BUILD_TESTS)
                     ${CMAKE_SOURCE_DIR}/tests
   )
 
-  if(ENABLE_V8)
-    add_e2e_test(
-      NAME auth_v8
-      PYTHON_SCRIPT
-        ${CMAKE_SOURCE_DIR}/tests/js-custom-authorization/custom_authorization.py
-      CONSENSUS cft
-      ADDITIONAL_ARGS --package libjs_v8 --js-app-bundle
-                      ${CMAKE_SOURCE_DIR}/tests
-    )
-  endif()
-
   if(LONG_TESTS)
     add_e2e_test(
       NAME launch_host_process_test
@@ -921,27 +898,6 @@ if(BUILD_TESTS)
       --msg-ser-fmt
       text
   )
-  if(ENABLE_V8)
-    add_perf_test(
-      NAME ls_v8
-      PYTHON_SCRIPT ${CMAKE_CURRENT_LIST_DIR}/tests/infra/perfclient.py
-      CONSENSUS cft
-      CLIENT_BIN ./scenario_perf_client
-      ADDITIONAL_ARGS
-        --package
-        libjs_v8
-        --js-app-bundle
-        ${CMAKE_SOURCE_DIR}/samples/apps/logging/js_perf
-        --scenario-file
-        ${CMAKE_CURRENT_LIST_DIR}/tests/perf_logging_scenario_100txs.json
-        --max-writes-ahead
-        1000
-        --repetitions
-        1000
-        --msg-ser-fmt
-        text
-    )
-  endif()
 
   add_perf_test(
     NAME ls_full_js
@@ -960,27 +916,6 @@ if(BUILD_TESTS)
       --msg-ser-fmt
       text
   )
-  if(ENABLE_V8)
-    add_perf_test(
-      NAME ls_full_v8
-      PYTHON_SCRIPT ${CMAKE_CURRENT_LIST_DIR}/tests/infra/perfclient.py
-      CONSENSUS cft
-      CLIENT_BIN ./scenario_perf_client
-      ADDITIONAL_ARGS
-        --package
-        libjs_v8
-        --js-app-bundle
-        ${CMAKE_SOURCE_DIR}/samples/apps/logging/js
-        --scenario-file
-        ${CMAKE_CURRENT_LIST_DIR}/tests/perf_logging_scenario_100txs.json
-        --max-writes-ahead
-        1000
-        --repetitions
-        1000
-        --msg-ser-fmt
-        text
-    )
-  endif()
 
   add_perf_test(
     NAME ls_js_jwt

diff --git a/THIRD_PARTY_NOTICES.txt b/THIRD_PARTY_NOTICES.txt
@@ -584,34 +584,3 @@ DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
--------------------------------------------------------------------
-
-v8/v8 f7528051b26ebd074f5695e7c412e1fc30f514c6 - BSD
-
-Copyright 2014, the V8 project authors. All rights reserved.
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions are
-met:
-
-    * Redistributions of source code must retain the above copyright
-      notice, this list of conditions and the following disclaimer.
-    * Redistributions in binary form must reproduce the above
-      copyright notice, this list of conditions and the following
-      disclaimer in the documentation and/or other materials provided
-      with the distribution.
-    * Neither the name of Google Inc. nor the names of its
-      contributors may be used to endorse or promote products derived
-      from this software without specific prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
diff --git a/cgmanifest.json b/cgmanifest.json
@@ -118,15 +118,6 @@
         }
       }
     },
-    {
-      "component": {
-        "type": "git",
-        "git": {
-          "repositoryUrl": "https://github.com/v8/v8",
-          "commitHash": "f7528051b26ebd074f5695e7c412e1fc30f514c6"
-        }
-      }
-    },
     {
       "component": {
         "type": "git",

diff --git a/cmake/common.cmake b/cmake/common.cmake
@@ -464,7 +464,6 @@ sign_app_library(
 )
 # SNIPPET_END: JS generic application
 
-include(${CCF_DIR}/cmake/js_v8.cmake)
 include(${CCF_DIR}/cmake/quictls.cmake)
 
 install(DIRECTORY ${CCF_DIR}/samples/apps/logging/js

diff --git a/cmake/js_v8.cmake b/cmake/js_v8.cmake
diff --git a/metrics.yml b/metrics.yml
@@ -8,7 +8,6 @@ pr_user: "ccf-bot"
 monitoring_issue: 1063
 monitoring_span: 150
 groups:
-  "V8": ".*_v8_.*"
   "SGX": ".*_sgx_.*"
   "Virtual": ".*_virtual_.*"
   "Others": ".*"