fix: Update promptflow version to 1.17.2 in Draft Flow #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UtkarshMishra-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft and
Prajwal-Microsoft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the promptflow dependency version in the Draft Flow environment and adjusts the AI Hub deployment script accordingly.
- Added an import for the time module.
- Modified the hub and project creation workflow by removing blocking .result() calls and instead using time.sleep delays followed by explicit retrieval.
- Updated comments to reflect the new asynchronous handling of resource creation.
Comments suppressed due to low confidence (1)
ResearchAssistant/Deployment/scripts/aihub_scripts/create_ai_hub.py:92
- [nitpick] The comment indicates waiting for the hub to be created, while this delay follows the project creation step. Update the comment to reflect that it is waiting for the project to be created.
time.sleep(30) # wait for hub to be created
Roopan-Microsoft
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The update from promptflow==1.17.0 to promptflow==1.17.2 under the "Draft Flow" folder includes improvements and bug fixes related to the version change.
The new version, 1.17.2, provides enhanced stability and possibly addresses issues present in 1.17.0, streamlining the flow management process within the Draft Flow environment.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information