Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quota check script with dynamic region handling #380

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

Priyanka-Microsoft
Copy link
Contributor

@Priyanka-Microsoft Priyanka-Microsoft commented Feb 26, 2025

Add the variable AZURE_REGIONS_CA with the value: northcentralus

Purpose

  • ...
    This pull request includes changes to the deployment scripts and workflow configuration to support dynamic Azure regions. The most important changes include adding a new environment variable for Azure regions and updating the quota check script to utilize this variable.

Workflow Configuration:

Deployment Script Updates:

Does this introduce a breaking change?

No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Copilot Copilot bot review requested due to automatic review settings February 26, 2025 08:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/CAdeploy.yml:29

  • The workflow exports AZURE_REGIONS while the updated script seems to expect the environment variable AZURE_REGIONS_CA. To avoid potential confusion or errors, consider aligning these variable names.
export AZURE_REGIONS="${{ vars.AZURE_REGIONS_CA }}"

@Roopan-Microsoft Roopan-Microsoft merged commit 82cc5c3 into main Feb 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants