ci: implement quota check in CI Pipeline to ensure resource availability in supported region for RA #376
+154
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gion and prevent failures due to insufficient quota.
Priyanka-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft and
Prajwal-Microsoft
as code owners
Priyanka-Microsoft
changed the title
Comment on lines
+30
to
+32
| if ! ResearchAssistant/Deployment/scripts/checkquota.sh; then | ||
| # If quota check fails due to insufficient quota, set the flag | ||
| if grep -q "No region with sufficient quota found" ResearchAssistant/Deployment/scripts/checkquota.sh; then |
There was a problem hiding this comment.
Using 'grep' on the script file to detect a quota check failure may not work as intended. Consider capturing and checking the output of the script execution instead.
Suggested change
| if ! ResearchAssistant/Deployment/scripts/checkquota.sh; then | |
| # If quota check fails due to insufficient quota, set the flag | |
| if grep -q "No region with sufficient quota found" ResearchAssistant/Deployment/scripts/checkquota.sh; then | |
| QUOTA_OUTPUT=$(ResearchAssistant/Deployment/scripts/checkquota.sh) | |
| if [ $? -ne 0 ]; then | |
| # If quota check fails due to insufficient quota, set the flag | |
| if echo "$QUOTA_OUTPUT" | grep -q "No region with sufficient quota found"; then |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Roopan-Microsoft
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces a new quota check mechanism in the deployment workflow to ensure sufficient resources are available before proceeding with the deployment. The most important changes include adding a quota check script, updating the deployment region based on quota availability, and handling quota check failures by sending notifications and failing the pipeline if necessary.
Quota check implementation:
.github/workflows/RAdeploy.yml: Added steps to run a quota check script, send a notification if the quota check fails, and fail the pipeline if necessary. [1] [2]Deployment region handling:
.github/workflows/RAdeploy.yml: Updated the deployment region to be set dynamically based on the results of the quota check.Quota check script:
ResearchAssistant/Deployment/scripts/checkquota.sh: Added a new script to check Azure regions for sufficient quota before proceeding with the deployment.Does this introduce a breaking change?
No
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information