Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update history method changes #294

Closed
wants to merge 2 commits into from
Closed

Conversation

pradeepjha-microsoft
Copy link
Contributor

@pradeepjha-microsoft pradeepjha-microsoft commented Jan 30, 2025

Purpose

This pull request includes changes to the ClientAdvisor/App/frontend/src/api/api.ts and ResearchAssistant/Deployment/scripts/aihub_scripts/requirements.txt files. The changes focus on adding a new utility function to handle empty arrays and updating dependencies in the requirements file.

Improvements to API functionality:

Does this introduce a breaking change?

  • Yes
  • [X ] No

Golden Path Validation - NA

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation - NA

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid
*

Other Information

Roopan-Microsoft and others added 2 commits January 13, 2025 17:28
* Downgrade msal[broker] to 1.24.0b1 and azure-mgmt-resource to 23.1.0b2

* Downgrade azure-ai-ml package to version 1.17.1 to resolve package version conflicts (#283)

* Upgrade azure-ai-ml package to compatible version

---------

Co-authored-by: Prasanjeet-Microsoft <[email protected]>
Co-authored-by: Prajwal-Microsoft <[email protected]>
@Copilot Copilot bot review requested due to automatic review settings January 30, 2025 11:32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

ClientAdvisor/App/frontend/src/api/api.ts:238

  • The error response creation using the spread operator is unconventional and might not work as intended. Consider using 'new Response(null, { status: 500, statusText: "Internal Server Error" })' instead.
const errRes: Response = {

ClientAdvisor/App/frontend/src/api/api.ts:241

  • [nitpick] The error response should include a more descriptive statusText, such as 'Empty messages array' or 'Invalid message format'.
status: 500
@pradeepjha-microsoft pradeepjha-microsoft changed the base branch from main to dev January 30, 2025 12:49
@pradeepjha-microsoft pradeepjha-microsoft deleted the psl-bug-12820 branch January 30, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants