Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent: allow displaying feedback inside activity actions toolbar #5407

Merged
merged 13 commits into from
Jan 14, 2025

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Jan 9, 2025

Changelog Entry

Added

  • (Experimental) Added feedbackActionsPlacement style option to control feedback button placement, in PR #5407, by @OEvgeny
    • New style option supports two values: 'activity-actions' and 'activity-status' (default)
    • When set to 'activity-actions', feedback buttons are displayed in the activity actions toolbar
    • When set to 'activity-status', feedback buttons appear in the activity status area (default behavior)

Description

This PR introduces a new style option that allows placing feedback buttons inside the activity actions toolbar instead of the activity status area.

Specific Changes

  • Added feedbackActionsPlacement style option in StyleOptions.ts
  • Created new ActivityFeedback component to handle feedback rendering
  • Moved feedback-related components to Activity folder
  • Reworked activity status slots to use CSS
  • Enhanced thumb button styling for activity actions placement
  • Added new tests for feedback placement functionality
  • Updated Fluent theme to use activity actions placement by default

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review January 14, 2025 01:12
compulim
compulim previously approved these changes Jan 14, 2025
@OEvgeny OEvgeny merged commit 4df27b8 into main Jan 14, 2025
27 checks passed
@OEvgeny OEvgeny deleted the feat/activity-feedback-actions branch January 14, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants