-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluent: allow displaying feedback inside activity actions toolbar #5407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
January 14, 2025 01:12
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
reviewed
Jan 14, 2025
compulim
previously approved these changes
Jan 14, 2025
compulim
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
feedbackActionsPlacement
style option to control feedback button placement, in PR #5407, by @OEvgeny'activity-actions'
and'activity-status'
(default)'activity-actions'
, feedback buttons are displayed in the activity actions toolbar'activity-status'
, feedback buttons appear in the activity status area (default behavior)Description
This PR introduces a new style option that allows placing feedback buttons inside the activity actions toolbar instead of the activity status area.
Specific Changes
feedbackActionsPlacement
style option in StyleOptions.tsActivityFeedback
component to handle feedback renderingCHANGELOG.md
I have updated documentationReview Checklist
z-index
)package.json
andpackage-lock.json
reviewed