Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support initial silence timeout #5400

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Support initial silence timeout #5400

merged 7 commits into from
Jan 7, 2025

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jan 7, 2025

Fixes #4890.

Changelog Entry

Added

  • Added support for speech recognition initial silence timeout when using Azure Speech, in PR #5400, by @compulim

Changed

Description

Added support of initialSilenceTimeout options, which is added in [email protected].

Specific Changes

  • Bumped to [email protected]
    • Added valibot to our transient dependencies
  • Passed initialSilenceTimeout to web-speech-cognitive-services
  • Added sample for configuring initial silence timeout
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review January 7, 2025 02:24
@compulim compulim enabled auto-merge (squash) January 7, 2025 02:57
Copy link
Collaborator

@OEvgeny OEvgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to cover this with end-to-end tests using your test framework?

@compulim compulim merged commit 5289ce3 into main Jan 7, 2025
27 checks passed
@compulim compulim deleted the bump-web-speech branch January 7, 2025 17:28
@tobiasvanderwerff
Copy link

@compulim Is it possible to add a parameter for EndSilenceTimeout as well? I.e. the length of time that a SpeechRecognizer detects silence (after recognition results have been generated) and assumes speech input has ended (https://learn.microsoft.com/en-us/windows/apps/design/input/set-speech-recognition-timeouts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to set properties of SpeechConfig in createCognitiveServicesSpeechServicesPonyfillFactory ?
3 participants