Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent: view code dialog #5337

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Fluent: view code dialog #5337

merged 7 commits into from
Oct 29, 2024

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Oct 28, 2024

Changelog Entry

  • Improved view code dialog UI in Fluent theme with better styling and accessibility, in PR #5337, by @OEvgeny

Description

This PR enhances the view code dialog component in the Fluent theme by implementing a modern, accessible design that aligns with Fluent UI principles.

Design

To account for dark/light theme this PR introduced codeBlockTheme style option. The code block theme should be passed manually if desired e.g. for dark themed Web Chat using Fluent skin pack 'github-dark-default' should be passed.

Specific Changes

  • Added codeBlockTheme style option with 'github-light-default' and 'github-dark-default' variants
  • [Fluent] Implemented responsive dialog layout with proper spacing and padding
  • Improved scrollbar styling for better integration
  • Enhanced focus states and keyboard navigation
  • Updated test files for UI verification

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

__tests__/html/fluentTheme/side-by-side.wide.dark.html Dismissed Show dismissed Hide dismissed
__tests__/html/fluentTheme/side-by-side.wide.html Dismissed Show dismissed Hide dismissed
@OEvgeny OEvgeny marked this pull request as ready for review October 29, 2024 00:22
@OEvgeny OEvgeny merged commit e5145f3 into main Oct 29, 2024
27 checks passed
@OEvgeny OEvgeny deleted the feature/fluent-view-code branch October 29, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants