Address XS code hygiene tasks

[OEvgeny]

part of #4968

Changelog Entry

Description

Address the first 3 suggestions from #4968

Design

Specific Changes

List of changes:

• XS: Do not use React FC/VFC types, use Props instead
• XS: Mark all props as read-only, also any arrays and objects under it
• XS: Prefer import { type ABC } over import type { ABC }

As we remove FC/VFC I thought it'd be nice to add ReactNode return type basically to:

• Serve as an additional hint that the function follows React Component signature
• Limit usage of unsupported by React runtime return types

-

• I have added tests and executed them locally
• I have updated CHANGELOG.md
• I have updated documentation

Review Checklist

This section is for contributors to review your work.

• Accessibility reviewed (tab order, content readability, alt text, color contrast)
• Browser and platform compatibilities reviewed
• CSS styles reviewed (minimal rules, no z-index)
• Documents reviewed (docs, samples, live demo)
• Internationalization reviewed (strings, unit formatting)
• package.json and package-lock.json reviewed
• Security reviewed (no data URIs, check for nonce leak)
• Tests reviewed (coverage, legitimacy)

[compulim]

This is my bad and lack of understanding about TypeScript couple of years ago. Could you help change this line to:

Suggested change

	type ActivityAcknowledgementComposerProps = Readonly<PropsWithChildren<{}>>;
	type ActivityAcknowledgementComposerProps = Readonly<{ children?: ReactNode | undefined }>;

In TypeScript, {} means any. And it means I can put whatever inside the props. Recently learn about type-fest package for TypeScript helpers. One of the helpers can define an empty object. 😉

[compulim]

Suggested change

	type ActivityKeyerComposerProps = Readonly<PropsWithChildren<{}>>;
	type ActivityKeyerComposerProps = Readonly<{ children?: ReactNode | undefined }>;

[compulim]

Suggested change

	type ActivitySendStatusComposerProps = Readonly<PropsWithChildren<{}>>;
	type ActivitySendStatusComposerProps = Readonly<{ children?: ReactNode | undefined }>;

[compulim]

Suggested change

	type ActivityTreeComposerProps = Readonly<PropsWithChildren<{}>>;
	type ActivityTreeComposerProps = Readonly<{ children?: ReactNode | undefined }>;

[OEvgeny]

Thanks William, good catch indead. I'll recreate the PR under the webchat repo for the CI PR pipeline to work