Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Releases/25.3] Backport of Reduce KV Checks for Embed ISV #2837

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

darjoo
Copy link
Contributor

@darjoo darjoo commented Jan 24, 2025

Summary

Backport of #2723 and #2781

Work Item(s)

Fixes AB#563283

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
ISV Embeds should be able to work with copilot and managed resources
without KV issues as they do not have the secrets needed and reduces the
effort that requires them to add specific secrets with empty values.

This does not enable them to run Microsoft 1st party copilot features on
their environments as they do not have the prompts.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#560368](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/560368)
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
The error was removed in #2723, this makes a test fail during uptake to
NAV.

Reverting the error and adding the Microsoft check.
Also reenabling that test. Will reenable the rest of the tests in
another PR.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#561929](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/561929)
@darjoo darjoo requested review from a team as code owners January 24, 2025 11:44
@github-actions github-actions bot added this to the Version 25.3 milestone Jan 24, 2025
@JesperSchulz JesperSchulz merged commit 1ccc30a into releases/25.3 Jan 24, 2025
26 checks passed
@JesperSchulz JesperSchulz deleted the bugs/563283 branch January 24, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants