Azure Document Intelligence Module #2834

Groenbech96 · 2025-01-23T13:12:10Z

Azure Document Intelligence support

OnPrem for now. Uptake available for 1p apps.
Move capabilities to Capabilities Impl Codeunit.
Introduce Azure AI Service Enum.
Hide Azure Doc Int. capabilities on the copilot pages based on PM feedback.

AB#563692

src/System Application/App/AI/src/DocumentIntelligence/AzureDIImpl.Codeunit.al

…BCApps into private/magnushar/ADI

NKarolak

Latin is nice, but maybe not popular enough ;-)

src/System Application/App/AI/src/DocumentIntelligence/ADIModelType.Enum.al

src/System Application/App/AI/src/DocumentIntelligence/AzureDIImpl.Codeunit.al

src/System Application/App/AI/src/DocumentIntelligence/ADIModelType.Enum.al

…te/magnushar/ADI

…BCApps into private/magnushar/ADI

darjoo

Good changes for introducing ADI, minor comments.

src/System Application/App/AI/src/Azure AI Document Intelligence/AzureDI.Codeunit.al

src/System Application/App/AI/src/Azure AI Document Intelligence/AzureDIImpl.Codeunit.al

src/System Application/App/AI/src/Azure AI Document Intelligence/ADIModelType.Enum.al

src/System Application/App/AI/src/Azure AI Document Intelligence/AzureDI.Codeunit.al

src/System Application/App/AI/src/Copilot/CopilotCapabilityImpl.Codeunit.al

Groenbech96

.

src/System Application/App/AI/src/Azure OpenAI/AzureOpenAIImpl.Codeunit.al

src/System Application/App/AI/src/Azure AI Document Intelligence/AzureDIImpl.Codeunit.al

….Codeunit.al

…ce/AzureDIImpl.Codeunit.al

…te/magnushar/ADI

... Application/App/AI/src/Azure AI Document Intelligence/AzureDocumentIntelligence.Codeunit.al

src/System Application/App/AI/src/Azure AI Document Intelligence/ADIModelType.Enum.al

src/System Application/App/AI/src/Copilot/CopilotCapEarlyPreview.Page.al

... Application/App/AI/src/Azure AI Document Intelligence/AzureDocumentIntelligence.Codeunit.al

…ce/AzureDocumentIntelligence.Codeunit.al Co-authored-by: encimita <[email protected]>

…ce/ADIModelType.Enum.al Co-authored-by: encimita <[email protected]>

…BCApps into private/magnushar/ADI

src/System Application/App/AI/src/Copilot/CopilotCapabilityImpl.Codeunit.al

src/System Application/App/AI/src/Azure OpenAI/AzureOpenAIImpl.Codeunit.al

src/System Application/App/AI/src/Copilot/CopilotCapabilityImpl.Codeunit.al

src/System Application/App/AI/src/Copilot/Interfaces/IAIServiceName.Interface.al

src/System Application/App/AI/src/Copilot/AzureAIServiceType.Enum.al

grobyns · 2025-02-11T09:11:44Z

You are free to ignore the comment but what you consider nitpicking, I do not... If I did, I would have said so or not commented at all. From: Magnus Hartvig Grønbech ***@***.***> Sent: Tuesday, 11 February 2025 09:57 To: microsoft/BCApps ***@***.***> Cc: Gert Robyns ***@***.***>; Review requested ***@***.***> Subject: Re: [microsoft/BCApps] Azure Document Intelligence Module (PR #2834) @Groenbech96 commented on this pull request.

________________________________ In src/System Application/App/AI/src/Copilot/Interfaces/IAIServiceName.Interface.al<#2834 (comment)>:

@@ -0,0 +1,25 @@

+// ------------------------------------------------------------------------------------------------ +// Copyright (c) Microsoft Corporation. All rights reserved. +// Licensed under the MIT License. See License.txt in the project root for license information. +// ------------------------------------------------------------------------------------------------ +namespace System.AI; + +/// <summary> +/// Interface for providing naming information for a given AI service. +/// </summary> +interface IAIServiceName nit wf. - Reply to this email directly, view it on GitHub<#2834 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AG2GJBIOSQO2NQCUP7U7LAT2PG3PNAVCNFSM6AAAAABVXKHPEWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMBYGA3DMNJUGM>. You are receiving this because your review was requested.Message ID: ***@***.******@***.***>>

This reverts commit a70b07c.

[AB#565088](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/565088)

This reverts commit f948ab1.

Reverts #2930 Fixes [AB#563692](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/563692) Co-authored-by: Magnus Hartvig Grønbech <[email protected]>

Add ADI

60e78da

Groenbech96 requested a review from a team as a code owner January 23, 2025 13:12

github-actions bot added the AL: System Application label Jan 23, 2025

tags

6e860fb

Groenbech96 changed the title ~~Add ADI~~ Azure Document Intelligence Module Jan 23, 2025

Jose-agg reviewed Jan 23, 2025

View reviewed changes

src/System Application/App/AI/src/DocumentIntelligence/AzureDIImpl.Codeunit.al Outdated Show resolved Hide resolved

Jose Antonio Garcia Garcia and others added 5 commits January 23, 2025 19:33

Minor corrections

838fba7

Fix unused label

b91bdb9

Merge branch 'private/magnushar/ADI' of https://github.com/microsoft/…

d3ab47c

…BCApps into private/magnushar/ADI

pack into json

e351912

Fix id

b002636

NKarolak suggested changes Jan 27, 2025

View reviewed changes

encimita reviewed Jan 28, 2025

View reviewed changes

src/System Application/App/AI/src/DocumentIntelligence/ADIModelType.Enum.al Outdated Show resolved Hide resolved

Magnus Hartvig Grønbech added 4 commits January 30, 2025 11:23

Update namespell

8b1a432

Can we decouple OpenAI and Copilot module

e0ea026

Merge branch 'main' of https://github.com/microsoft/BCApps into priva…

8ce1c7d

…te/magnushar/ADI

Merge branch 'private/magnushar/ADI' of https://github.com/microsoft/…

71304a5

…BCApps into private/magnushar/ADI

darjoo reviewed Feb 3, 2025

View reviewed changes

Magnus Hartvig Grønbech added 2 commits February 5, 2025 15:01

Move abstraction around

893bb6b

Update text

6dc545b

darjoo reviewed Feb 5, 2025

View reviewed changes

src/System Application/App/AI/src/Copilot/CopilotCapabilityImpl.Codeunit.al Outdated Show resolved Hide resolved

src/System Application/App/AI/src/Copilot/CopilotCapabilityImpl.Codeunit.al Outdated Show resolved Hide resolved

Clear before insert.

f791b25

github-actions bot added this to the Version 26.0 milestone Feb 6, 2025

Groenbech96 commented Feb 6, 2025

View reviewed changes

src/System Application/App/AI/src/Azure OpenAI/AzureOpenAIImpl.Codeunit.al Outdated Show resolved Hide resolved

src/System Application/App/AI/src/Azure AI Document Intelligence/AzureDIImpl.Codeunit.al Outdated Show resolved Hide resolved

Groenbech96 added 2 commits February 6, 2025 08:22

Update src/System Application/App/AI/src/Azure OpenAI/AzureOpenAIImpl…

a61ba61

….Codeunit.al

Update src/System Application/App/AI/src/Azure AI Document Intelligen…

5ca1c58

…ce/AzureDIImpl.Codeunit.al

darjoo previously approved these changes Feb 6, 2025

View reviewed changes

Add field to table, to exclude from pages

1ce1417

Groenbech96 dismissed darjoo’s stale review via 1ce1417 February 10, 2025 10:51

Merge branch 'main' of https://github.com/microsoft/BCApps into priva…

85abf9f

…te/magnushar/ADI

mynjj previously approved these changes Feb 10, 2025

View reviewed changes

... Application/App/AI/src/Azure AI Document Intelligence/AzureDocumentIntelligence.Codeunit.al Outdated Show resolved Hide resolved

Fix comment

89bb33f

Groenbech96 dismissed mynjj’s stale review via 89bb33f February 10, 2025 15:16

encimita previously approved these changes Feb 10, 2025

View reviewed changes

Update src/System Application/App/AI/src/Azure AI Document Intelligen…

44f54d2

…ce/AzureDocumentIntelligence.Codeunit.al Co-authored-by: encimita <[email protected]>

Groenbech96 dismissed encimita’s stale review via 44f54d2 February 10, 2025 16:10

Groenbech96 and others added 3 commits February 10, 2025 17:10

Update src/System Application/App/AI/src/Azure AI Document Intelligen…

ade6490

…ce/ADIModelType.Enum.al Co-authored-by: encimita <[email protected]>

tests

2ddd7f3

Merge branch 'private/magnushar/ADI' of https://github.com/microsoft/…

0787dfd

…BCApps into private/magnushar/ADI

Groenbech96 requested a review from a team as a code owner February 10, 2025 16:30

msft-sam reviewed Feb 10, 2025

View reviewed changes

pr comments

db18633

Groenbech96 requested a review from msft-sam February 11, 2025 06:11

darjoo reviewed Feb 11, 2025

View reviewed changes

src/System Application/App/AI/src/Copilot/CopilotCapabilityImpl.Codeunit.al Show resolved Hide resolved

grobyns reviewed Feb 11, 2025

View reviewed changes

src/System Application/App/AI/src/Copilot/Interfaces/IAIServiceName.Interface.al Outdated Show resolved Hide resolved

msft-sam previously approved these changes Feb 11, 2025

View reviewed changes

msft-sam reviewed Feb 11, 2025

View reviewed changes

src/System Application/App/AI/src/Copilot/AzureAIServiceType.Enum.al Outdated Show resolved Hide resolved

Minor

c9fccf1

Jose-agg dismissed msft-sam’s stale review via c9fccf1 February 11, 2025 09:15

rename interface

17509fa

darjoo approved these changes Feb 11, 2025

View reviewed changes

msft-sam approved these changes Feb 11, 2025

View reviewed changes

Groenbech96 enabled auto-merge (squash) February 11, 2025 10:28

Groenbech96 merged commit a70b07c into main Feb 11, 2025
24 checks passed

Groenbech96 deleted the private/magnushar/ADI branch February 11, 2025 10:33

mazhelez added a commit that referenced this pull request Feb 12, 2025

Revert "Azure Document Intelligence Module (#2834)"

7613c92

This reverts commit a70b07c.

mazhelez added a commit that referenced this pull request Feb 12, 2025

Revert "Azure Document Intelligence Module" (#2834) (#2930)

f948ab1

[AB#565088](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/565088)

Groenbech96 added a commit that referenced this pull request Feb 12, 2025

Revert "Revert "Azure Document Intelligence Module" (#2834) (#2930)"

28009b1

This reverts commit f948ab1.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure Document Intelligence Module #2834

Azure Document Intelligence Module #2834

Groenbech96 commented Jan 23, 2025 •

edited by github-actions bot

Loading

NKarolak left a comment

darjoo left a comment

Groenbech96 left a comment

grobyns commented Feb 11, 2025 via email

Azure Document Intelligence Module #2834

Azure Document Intelligence Module #2834

Conversation

Groenbech96 commented Jan 23, 2025 • edited by github-actions bot Loading

NKarolak left a comment

Choose a reason for hiding this comment

darjoo left a comment

Choose a reason for hiding this comment

Groenbech96 left a comment

Choose a reason for hiding this comment

grobyns commented Feb 11, 2025 via email

Groenbech96 commented Jan 23, 2025 •

edited by github-actions bot

Loading