-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application Insights warning on llm model deprecation #2524
Merged
christian-andersen-msft
merged 16 commits into
main
from
isv-telemetry-on-llm-deprecation-rebranch
Jan 17, 2025
Merged
Application Insights warning on llm model deprecation #2524
christian-andersen-msft
merged 16 commits into
main
from
isv-telemetry-on-llm-deprecation-rebranch
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…nications to signal model changes on CAPI/managed AI resources
Readability and structure improvements Co-authored-by: Natalie Karolak, MVP <[email protected]>
…thub.com/microsoft/BCApps into isv-telemetry-on-llm-deprecation-rebranch
…elemetry-on-llm-deprecation-rebranch
Issue #548931 is not valid. Please make sure you link an issue that exists, is open and is approved. |
christian-andersen-msft
changed the title
Isv telemetry on llm deprecation rebranch
Application Insights warning on llm model deprecation
Dec 12, 2024
christian-andersen-msft
requested review from
encimita,
msft-sam and
haoranpb
December 12, 2024 10:22
haoranpb
previously approved these changes
Dec 12, 2024
encimita
previously approved these changes
Dec 13, 2024
src/System Application/App/AI/src/Azure OpenAI/AOAIDeploymentsImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/AI/src/Azure OpenAI/AOAIDeploymentsImpl.Codeunit.al
Show resolved
Hide resolved
src/System Application/App/AI/src/Azure OpenAI/AOAIDeploymentsImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
… and added CLEAN25 tag to older model deprecation dates
christian-andersen-msft
dismissed stale reviews from encimita and haoranpb
via
January 8, 2025 16:10
31bb828
msft-sam
reviewed
Jan 8, 2025
src/System Application/App/AI/src/Azure OpenAI/AOAIDeploymentsImpl.Codeunit.al
Show resolved
Hide resolved
darjoo
reviewed
Jan 14, 2025
src/System Application/App/AI/src/Azure OpenAI/AOAIDeploymentsImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/AI/src/Azure OpenAI/AOAIDeploymentsImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
haoranpb
previously approved these changes
Jan 14, 2025
encimita
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Left a followup to Darrick's comment, I think we should fix that and then we are ready for merging the PR!
src/System Application/App/AI/src/Azure OpenAI/AOAIDeploymentsImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
darjoo
approved these changes
Jan 16, 2025
encimita
approved these changes
Jan 16, 2025
christian-andersen-msft
deleted the
isv-telemetry-on-llm-deprecation-rebranch
branch
January 17, 2025 10:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use of deprecated llm models in extensions will be logged in 3rd party Application Insights with a warning
Work Item(s)
Fixes AB#548931