Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLEANSCHEMA symbols #2065

Merged
merged 25 commits into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
a2418a2
add CLEANSCHEMA symbols
grobyns Sep 19, 2024
2199b34
Merge branch 'main' of https://github.com/microsoft/BCApps into featu…
grobyns Sep 19, 2024
eac961b
Port the gate for testing app clean symbols
mazhelez Sep 19, 2024
4eda538
Fix typo
mazhelez Sep 19, 2024
b7d4605
Merge branch 'main' of https://github.com/microsoft/BCApps into mazhe…
mazhelez Sep 20, 2024
ce43d16
Adapt script to BCApps (#2072)
mazhelez Sep 20, 2024
1deb205
Merge branch 'main' of https://github.com/microsoft/BCApps into featu…
grobyns Sep 20, 2024
f2f1782
Merge branch 'mazhelez/add-verifyappchanges-check' of https://github.…
grobyns Sep 20, 2024
8fe9f6b
script changes
grobyns Sep 20, 2024
18003a3
review comment
grobyns Sep 20, 2024
bd00fbe
fix whitespace
grobyns Sep 20, 2024
0913524
comments
grobyns Sep 20, 2024
0b1c1b9
cuz maria said so
grobyns Sep 20, 2024
9e3000a
review comment
grobyns Sep 20, 2024
e97ff84
move pester tests
grobyns Sep 20, 2024
8095f7b
Add job to run PS tests
mazhelez Sep 20, 2024
c9fb219
Merge branch 'features/549296' of https://github.com/microsoft/BCApps…
mazhelez Sep 20, 2024
8fa24f1
Add runTests.ps1
mazhelez Sep 20, 2024
c22aad0
Fix failing tests
mazhelez Sep 20, 2024
3e3f7f0
review comments
grobyns Sep 23, 2024
1550886
let's see if this works
grobyns Sep 23, 2024
cedb78a
Rename action folder
mazhelez Sep 23, 2024
07fac42
Use SHA for action ref (to be changed to main afterwards)
mazhelez Sep 23, 2024
a35a643
Rename workflow
mazhelez Sep 23, 2024
9119ba3
Merge branch 'main' of https://github.com/microsoft/BCApps into featu…
mazhelez Sep 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ tableextension 230 ObsoleteSourceCodeExt extends "Source Code"
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
ObsoleteTag = '25.0';
}
#if not CLEANSCHEMA15
field(10620; "SAFT Source Code"; Code[9])
{
Caption = 'SAF-T Source Code';
Expand All @@ -28,6 +29,7 @@ tableextension 230 ObsoleteSourceCodeExt extends "Source Code"
ObsoleteTag = '15.0';
#pragma warning restore AS0072
}
#endif
field(28160; Simulation; Boolean)
{
Caption = 'Simulation';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,7 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '25.0';
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
}
#if not CLEANSCHEMA15
field(11200; "Inward Registration"; Code[10])
{
Caption = 'Inward Registration';
Expand All @@ -849,6 +850,7 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '15.0';
#pragma warning restore AS0072
}
#endif
field(11307; "Financial Journal"; Code[10])
{
Caption = 'Financial Journal';
Expand Down Expand Up @@ -879,6 +881,7 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '25.0';
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
}
#if not CLEANSCHEMA20
field(11760; "Purchase VAT Delay"; Code[10])
{
Caption = 'Purchase VAT Delay';
Expand All @@ -901,6 +904,8 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '20.0';
#pragma warning restore AS0072
}
#endif
#if not CLEANSCHEMA18
field(11762; "VAT Coefficient"; Code[10])
{
Caption = 'VAT Coefficient';
Expand All @@ -912,6 +917,8 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '18.0';
#pragma warning restore AS0072
}
#endif
#if not CLEANSCHEMA22
field(11764; "Close Balance Sheet"; Code[10])
{
Caption = 'Close Balance Sheet';
Expand All @@ -934,6 +941,8 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '22.0';
#pragma warning restore AS0072
}
#endif
#if not CLEANSCHEMA20
field(11766; "Cash Desk"; Code[10])
{
Caption = 'Cash Desk';
Expand All @@ -945,6 +954,7 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '20.0';
#pragma warning restore AS0072
}
#endif
field(12400; "Advance Statements"; Code[10])
{
Caption = 'Advance Statements';
Expand Down Expand Up @@ -1065,6 +1075,7 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '25.0';
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
}
#if not CLEANSCHEMA21
field(12450; "Item Receipt"; Code[10])
{
Caption = 'Item Receipt';
Expand All @@ -1087,6 +1098,7 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '21.0';
#pragma warning restore AS0072
}
#endif
field(12470; "FA Release"; Code[10])
{
Caption = 'FA Release';
Expand Down Expand Up @@ -1147,6 +1159,7 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '25.0';
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
}
#if not CLEANSCHEMA18
field(31041; "Maintenance Adjustment"; Code[10])
{
Caption = 'Maintenance Adjustment';
Expand All @@ -1158,6 +1171,8 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '18.0';
#pragma warning restore AS0072
}
#endif
#if not CLEANSCHEMA21
field(31050; Credit; Code[10])
{
Caption = 'Credit';
Expand All @@ -1169,6 +1184,7 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '21.0';
#pragma warning restore AS0072
}
#endif
#pragma warning disable AS0013
field(2000020; "Domiciliation Journal"; Code[10])
{
Expand All @@ -1190,6 +1206,7 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '25.0';
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
}
#if not CLEANSCHEMA24
field(5005350; "Phys. Invt. Order"; Code[10])
{
Caption = 'Phys. Invt. Order';
Expand All @@ -1201,6 +1218,7 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '24.0';
#pragma warning restore AS0072
}
#endif
field(7000000; "Cartera Journal"; Code[10])
{
Caption = 'Cartera Journal';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA27
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -183,4 +184,5 @@ tableextension 309 NoSeriesLineObsolete extends "No. Series Line"
end;
#endif

}
}
#endif
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA27
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -149,3 +150,4 @@ table 12146 "No. Series Line Purchase"
}
}
}
#endif
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA27
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -149,3 +150,4 @@ table 12145 "No. Series Line Sales"
}
}
}
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ tableextension 308 NoSeriesObsolete extends "No. Series"
{
fields
{
#if not CLEANSCHEMA18
field(11790; Mask; Text[20]) // CZ Functionality
{
Caption = 'Mask';
Expand All @@ -20,6 +21,7 @@ tableextension 308 NoSeriesObsolete extends "No. Series"
ObsoleteState = Removed;
ObsoleteTag = '18.0';
}
#endif
#pragma warning disable AL0432
field(12100; "No. Series Type"; Integer)
#pragma warning restore AL0432
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@ table 8904 "Email Message Attachment"
DataClassification = SystemMetadata;
TableRelation = "Email Message".Id;
}
#if not CLEANSCHEMA18
field(3; Attachment; Blob)
{
DataClassification = CustomerContent;
ObsoleteState = Removed;
ObsoleteReason = 'Field has been replaced with the media field, Data.';
ObsoleteTag = '18.1';
}
#endif
field(4; "Attachment Name"; Text[250])
{
DataClassification = CustomerContent;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA27
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -370,3 +371,4 @@ table 2010 "Azure OpenAi Settings"
TelemetryTotalIslandsInvalidTxt: Label 'The total islands config key is not set or is not a number.', Locked = true;
#endif
}
#endif
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA19
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -91,4 +92,4 @@ table 1808 "Aggregated Assisted Setup"
}
}
}

#endif
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA23
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -194,4 +195,4 @@ table 1803 "Assisted Setup"
Translation.Delete(Rec);
end;
}

#endif
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA19
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -42,4 +43,4 @@ table 1810 "Assisted Setup Icons"
}
}
}

#endif
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA23
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -56,4 +57,4 @@ table 1807 "Assisted Setup Log"
}

}

#endif
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA19
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -52,4 +53,4 @@ table 1471 "Product Video Category"
}

}

#endif
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA23
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -45,4 +46,4 @@ table 1876 "Business Setup Icon"
}

}

#endif
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA23
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -77,3 +78,4 @@ table 3700 "Manual Setup"
}
}
#pragma warning restore AS0039
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,15 @@ table 1432 "Net Promoter Score Setup"
{
DataClassification = SystemMetadata;
}
#if not CLEANSCHEMA18
field(4; "Time Between Requests"; Integer)
{
DataClassification = SystemMetadata;
ObsoleteReason = 'This field is not needed and it is not used anymore.';
ObsoleteState = Removed;
ObsoleteTag = '18.0';
}
#endif
field(5; "Request Timeout"; Integer)
{
DataClassification = SystemMetadata;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA23
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -47,3 +48,4 @@ table 2889 "Query Navigation Validation"
}
}
}
#endif
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA23
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -51,4 +52,5 @@ table 2888 "SmartList Designer Handler"
Clustered = true;
}
}
}
}
#endif
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#if not CLEANSCHEMA23
// ------------------------------------------------------------------------------------------------
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
Expand Down Expand Up @@ -39,4 +40,5 @@ table 9173 "Extra Settings"
Clustered = true;
}
}
}
}
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ table 1470 "Product Video Buffer"
DataClassification = SystemMetadata;
Editable = false;
}
#if not CLEANSCHEMA18
field(4; "Assisted Setup ID"; Integer)
{
Caption = 'Assisted Setup ID';
Expand All @@ -56,6 +57,7 @@ table 1470 "Product Video Buffer"
ObsoleteReason = 'Product videos are no more grouped.';
ObsoleteTag = '18.0';
}
#endif
field(6; "Table Num"; Integer)
{
DataClassification = SystemMetadata;
Expand Down
Loading