Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] "Swiss QR-Bill Incoming Doc" UpdatePurchDocFromIncDoc Don't Override Purchase Field #28301

Merged

Conversation

PeterDurrer
Copy link
Contributor

@PeterDurrer PeterDurrer commented Mar 3, 2025

Summary

Don't Override Purchase Field if empty in QRCode

Work Item(s)

Fixes #28300

Fixes AB#568198

Don't Override Purchase Field if empty in QRCode
@PeterDurrer PeterDurrer changed the title "Swiss QR-Bill Incoming Doc" UpdatePurchDocFromIncDoc "Swiss QR-Bill Incoming Doc" UpdatePurchDocFromIncDoc Don't Override Purchase Field Mar 3, 2025
@AleksanderGladkov
Copy link
Contributor

@PeterDurrer You will need to create test(s) for this change.
See the Apps\CH\SwissQRBill\test\src folder with existing tests and add yours.

@PeterDurrer

This comment was marked as resolved.

@JesperSchulz JesperSchulz changed the title "Swiss QR-Bill Incoming Doc" UpdatePurchDocFromIncDoc Don't Override Purchase Field [DRAFT] "Swiss QR-Bill Incoming Doc" UpdatePurchDocFromIncDoc Don't Override Purchase Field Mar 5, 2025
@JesperSchulz JesperSchulz added the Finance GitHub request for Finance area label Mar 5, 2025
@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Mar 7, 2025
Don't Override Purchase Field if empty in QRCode
@PeterDurrer PeterDurrer force-pushed the bugfix/QROverrideFieldsWithEmptyValues branch from b6e3064 to d65c301 Compare March 7, 2025 15:04
@PeterDurrer PeterDurrer changed the title [DRAFT] "Swiss QR-Bill Incoming Doc" UpdatePurchDocFromIncDoc Don't Override Purchase Field [BugFix] "Swiss QR-Bill Incoming Doc" UpdatePurchDocFromIncDoc Don't Override Purchase Field Mar 7, 2025
@PeterDurrer PeterDurrer marked this pull request as ready for review March 7, 2025 15:11
@PeterDurrer PeterDurrer requested a review from a team as a code owner March 7, 2025 15:11
@PeterDurrer PeterDurrer requested a review from VolodySyn March 7, 2025 15:11
@PeterDurrer

This comment has been minimized.

Don't Override Purchase Field if empty in QRCode
@PeterDurrer

This comment has been minimized.

@AleksanderGladkov
Copy link
Contributor

@PeterDurrer I updated the tests according to internal best practices + fix compilation errors, and commited the changes.
If you are going to contribute in future, please read this contribution guide - it will give you understanding for how to setup local development environment to build and run your code.

@PeterDurrer

This comment has been minimized.

@PeterDurrer
Copy link
Contributor Author

@PeterDurrer I updated the tests according to internal best practices + fix compilation errors, and commited the changes.
If you are going to contribute in future, please read this contribution guide - it will give you understanding for how to setup local development environment to build and run your code.

@AleksanderGladkov Thank you it looks very good. It's New for me write Test Code in Microsoft Apps. Thanks for the link i will do my best to get better work on the other PullRequests. At the moment i have some Problems on my Machine to run the localDevEnv script for this repo i hope i can resolve them quickly.

@JesperSchulz or @VolodySyn Can you Review the PullRequest i can not approve the changes from @AleksanderGladkov but it looks good for me.

@JesperSchulz JesperSchulz self-assigned this Mar 25, 2025
@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Mar 25, 2025
Copy link
Contributor

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

@JesperSchulz JesperSchulz merged commit 558bf06 into microsoft:main Mar 26, 2025
9 checks passed
@PeterDurrer PeterDurrer deleted the bugfix/QROverrideFieldsWithEmptyValues branch March 26, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Finance GitHub request for Finance area linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed
Projects
None yet
3 participants