[Shopify] Dispute processing in Shopify (Payments module) #25753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree [company="Vetatek"] |
|
@microsoft-github-policy-service agree |
daniloziva
changed the title
pri-kise
reviewed
Jan 22, 2024
onbuyuka
previously requested changes
Jan 22, 2024
Apps/W1/Shopify/app/src/Payments/Codeunits/ShpfyPayments.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Payments/Codeunits/ShpfyPayments.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Payments/Enums/ShpfyPaymentTransDisputeStatus.Enum.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Payments/Enums/ShpfyPaymentTransDisputeStatus.Enum.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Payments/Reports/ShpfySyncDisputes.Report.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Payments/Reports/ShpfySyncDisputes.Report.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Payments/Reports/ShpfySyncDisputes.Report.al
Outdated
Show resolved
Hide resolved
Added test too |
|
I've updated the PR with requested changes. Please review and let me know |
Can you please review the code and let me know if there's anything else you would like to see? |
onbuyuka
reviewed
Jan 26, 2024
Apps/W1/Shopify/app/src/Payments/Codeunits/ShpfyPayments.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Payments/Codeunits/ShpfyPayments.Codeunit.al
Outdated
Show resolved
Hide resolved
JesperSchulz
reviewed
Apr 8, 2024
Apps/W1/Shopify/app/src/Payments/Codeunits/ShpfyPayments.Codeunit.al
Outdated
Show resolved
Hide resolved
haoranpb
previously approved these changes
Apr 9, 2024
JesperSchulz
reviewed
Apr 9, 2024
Apps/W1/Shopify/app/src/Payments/Codeunits/ShpfyPayments.Codeunit.al
Outdated
Show resolved
Hide resolved
nikolakukrika
previously approved these changes
Apr 9, 2024
JesperSchulz
reviewed
Apr 9, 2024
onbuyuka
previously approved these changes
Apr 10, 2024
Apps/W1/Shopify/app/src/Payments/Codeunits/ShpfyPayments.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Payments/Enums/ShpfyDisputeReason.Enum.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Payments/Enums/ShpfyDisputeStatus.Enum.al
Outdated
Show resolved
Hide resolved
Apps/W1/Shopify/app/src/Payments/Enums/ShpfyDisputeType.Enum.al
Outdated
Show resolved
Hide resolved
Ported all changes as checked into the main repo.
1 task
JesperSchulz
approved these changes
Apr 10, 2024
onbuyuka
approved these changes
Apr 10, 2024
|
Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one. Build ID: 18225. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a dispute related to a payment transaction, there is no clear way to see the status of the dispute and the finalized date within BC.
The committed code enables this. I have added an Enum that represents the dispute statuses from Shopify, and mapped them accordingly.
UpdateDisputeStatus() function in ShpfyPayments.Codeunit.al gets the list of disputes from the Shopify API, and updates the data in BC.
Considering that dispute processing is an async task and might happen at any point in time, I pull the data from Shopify via the report "Shpfy Sync Disputes", that can be scheduled via Job queue.
On another note, with the updates to the Disputes, values from "Shpfy Payment Transcation Type" would be very valued for extensibility purposes, so I removed the Internal access.
Fixes #26262
Fixes AB#498566