GP Unit accounts migrated as BC Statistical accounts (#26498)

This PR enhances the GP migration by migrating Unit accounts as BC
Statistical accounts.

- Updated the Account migrator to include Unit accounts, and handle them
separately from the G/L Account related code.
- Statistical Account posting logic.
- Added count of unposted Statistical account batches to the Failed
Batches tile.
- Added unit tests.

Fixes #26487
Fixes
[AB#537203](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/537203)

---------

Co-authored-by: jaymckinney <[email protected]>

Author: jaymckinney-enavate

Apps/W1/HybridGP/app/app.json

@@ -28,8 +28,14 @@
                              "id":  "c526b3e9-b8ca-4683-81ba-fcd5f6b1472a",
                              "name":  "Sales and Inventory Forecast",
                              "publisher":  "Microsoft",
-                             "version":  "25.0.0.0"
-                         }
+                            "version": "25.0.0.0"
+                        },
+                        {
+                            "id": "ea130081-c669-460f-a5f4-5dde14f03131",
+                            "name": "Statistical Accounts",
+                            "publisher": "Microsoft",
+                            "version": "25.0.0.0"
+                        }
                      ],
     "screenshots":  [
 

Apps/W1/HybridGP/app/src/Migration/Accounts/GPAccountMigrator.codeunit.al

@@ -4,6 +4,8 @@ using System.Integration;
 using Microsoft.Finance.GeneralLedger.Journal;
 using Microsoft.Finance.Dimension;
 using Microsoft.Finance.GeneralLedger.Account;
+using Microsoft.Finance.Analysis.StatisticalAccount;
+using Microsoft.Finance.GeneralLedger.Setup;
 
 codeunit 4017 "GP Account Migrator"
 {
@@ -45,7 +47,6 @@ codeunit 4017 "GP Account Migrator"
     local procedure OnMigrateAccountTransactions(var Sender: Codeunit "GL Acc. Data Migration Facade"; RecordIdToMigrate: RecordId)
     var
         GPAccount: Record "GP Account";
-        GLAccount: Record "G/L Account";
         GPCompanyAdditionalSettings: Record "GP Company Additional Settings";
     begin
         if RecordIdToMigrate.TableNo() <> Database::"GP Account" then
@@ -59,9 +60,6 @@ codeunit 4017 "GP Account Migrator"
 
         GPAccount.Get(RecordIdToMigrate);
 
-        if not GLAccount.Get(GPAccount.AcctNum) then
-            exit;
-
         GenerateGLTransactionBatches(GPAccount);
     end;
 
@@ -81,6 +79,9 @@ codeunit 4017 "GP Account Migrator"
 
         GPAccount.Get(RecordIdToMigrate);
 
+        if GPAccount.AccountType <> 1 then
+            exit;
+
         if not GLAccount.Get(GPAccount.AcctNum) then
             exit;
 
@@ -120,7 +121,6 @@ codeunit 4017 "GP Account Migrator"
     local procedure OnCreateOpeningBalanceTrx(var Sender: Codeunit "GL Acc. Data Migration Facade"; RecordIdToMigrate: RecordId)
     var
         GPAccount: Record "GP Account";
-        GLAccount: Record "G/L Account";
         GPCompanyAdditionalSettings: Record "GP Company Additional Settings";
     begin
         if RecordIdToMigrate.TableNo() <> Database::"GP Account" then
@@ -136,14 +136,22 @@ codeunit 4017 "GP Account Migrator"
         if GPAccount.IncomeBalance then
             exit;
 
-        if not GLAccount.Get(GPAccount.AcctNum) then
-            exit;
-
         CreateBeginningBalance(GPAccount);
     end;
 
     procedure CreateBeginningBalance(GPAccount: Record "GP Account")
+    begin
+        case GPAccount.AccountType of
+            1:
+                CreateGLAccountBeginningBalanceImp(GPAccount);
+            2:
+                CreateStatisticalAccountBeginningBalanceImp(GPAccount);
+        end;
+    end;
+
+    local procedure CreateGLAccountBeginningBalanceImp(GPAccount: Record "GP Account")
     var
+        GLAccount: Record "G/L Account";
         GPGL10111: Record "GP GL10111";
         GenJournalLine: Record "Gen. Journal Line";
         GPFiscalPeriods: Record "GP Fiscal Periods";
@@ -162,6 +170,9 @@ codeunit 4017 "GP Account Migrator"
         ACTNUMBR_8: Code[20];
         DimSetID: Integer;
     begin
+        if not GLAccount.Get(GPAccount.AcctNum) then
+            exit;
+
         InitialYear := GPCompanyAdditionalSettings.GetInitialYear();
         if InitialYear = 0 then
             exit;
@@ -176,7 +187,7 @@ codeunit 4017 "GP Account Migrator"
         if BeginningBalance = 0 then
             exit;
 
-        PostingGroupCode := PostingGroupCodeTxt + format(InitialYear) + 'BB';
+        PostingGroupCode := PostingGroupCodeTxt + Format(InitialYear) + 'BB';
         if GPFiscalPeriods.Get(0, InitialYear) then begin
             DataMigrationFacadeHelper.CreateGeneralJournalBatchIfNeeded(CopyStr(PostingGroupCode, 1, 10), '', '');
             DataMigrationFacadeHelper.CreateGeneralJournalLine(
@@ -212,7 +223,100 @@ codeunit 4017 "GP Account Migrator"
         end;
     end;
 
+    local procedure CreateStatisticalAccountBeginningBalanceImp(GPAccount: Record "GP Account")
+    var
+        GPGL00100: Record "GP GL00100";
+        GPGL10111: Record "GP GL10111";
+        GPCompanyAdditionalSettings: Record "GP Company Additional Settings";
+        GPFiscalPeriods: Record "GP Fiscal Periods";
+        StatisticalAccJournalBatch: Record "Statistical Acc. Journal Batch";
+        StatisticalAccJournalLine: Record "Statistical Acc. Journal Line";
+        StatisticalAccJournalLineCurrent: Record "Statistical Acc. Journal Line";
+        InitialYear: Integer;
+        BeginningBalance: Decimal;
+        DocumentNo: Code[20];
+        LineNum: Integer;
+        ACTNUMBR_1: Code[20];
+        ACTNUMBR_2: Code[20];
+        ACTNUMBR_3: Code[20];
+        ACTNUMBR_4: Code[20];
+        ACTNUMBR_5: Code[20];
+        ACTNUMBR_6: Code[20];
+        ACTNUMBR_7: Code[20];
+        ACTNUMBR_8: Code[20];
+        DimSetID: Integer;
+    begin
+        InitialYear := GPCompanyAdditionalSettings.GetInitialYear();
+        if InitialYear = 0 then
+            exit;
+
+        if not GPGL00100.Get(GPAccount.AcctIndex) then
+            exit;
+
+        if GPGL00100.Clear_Balance then
+            exit;
+
+        GPGL10111.SetRange(ACTINDX, GPAccount.AcctIndex);
+        GPGL10111.SetRange(PERIODID, 0);
+        GPGL10111.SetRange(YEAR1, InitialYear);
+        if not GPGL10111.FindFirst() then
+            exit;
+
+        BeginningBalance := GPGL10111.PERDBLNC;
+        if BeginningBalance = 0 then
+            exit;
+
+        DocumentNo := PostingGroupCodeTxt + Format(InitialYear) + 'BB';
+        if GPFiscalPeriods.Get(0, InitialYear) then begin
+            if not StatisticalAccJournalBatch.Get('', DocumentNo) then begin
+                StatisticalAccJournalBatch.Validate(Name, DocumentNo);
+                StatisticalAccJournalBatch.Insert(true);
+            end;
+
+            StatisticalAccJournalLineCurrent.SetRange("Journal Batch Name", StatisticalAccJournalBatch.Name);
+            if StatisticalAccJournalLineCurrent.FindLast() then
+                LineNum := StatisticalAccJournalLineCurrent."Line No." + 10000
+            else
+                LineNum := 10000;
+
+            StatisticalAccJournalLine.Validate("Journal Batch Name", DocumentNo);
+            StatisticalAccJournalLine.Validate("Line No.", LineNum);
+            StatisticalAccJournalLine.Validate("Document No.", DocumentNo);
+            StatisticalAccJournalLine.Validate(Description, CopyStr(BeginningBalanceTrxTxt, 1, MaxStrLen(StatisticalAccJournalLine.Description)));
+            StatisticalAccJournalLine.Validate("Statistical Account No.", CopyStr(GPAccount.AcctNum, 1, MaxStrLen(StatisticalAccJournalLine."Statistical Account No.")));
+            StatisticalAccJournalLine.Validate("Posting Date", GPFiscalPeriods.PERIODDT);
+            StatisticalAccJournalLine.Validate(Amount, BeginningBalance);
+            StatisticalAccJournalLine.Insert();
+
+            ACTNUMBR_1 := GPGL10111.ACTNUMBR_1;
+            ACTNUMBR_2 := GPGL10111.ACTNUMBR_2;
+            ACTNUMBR_3 := GPGL10111.ACTNUMBR_3;
+            ACTNUMBR_4 := GPGL10111.ACTNUMBR_4;
+            ACTNUMBR_5 := GPGL10111.ACTNUMBR_5;
+            ACTNUMBR_6 := GPGL10111.ACTNUMBR_6;
+            ACTNUMBR_7 := GPGL10111.ACTNUMBR_7;
+            ACTNUMBR_8 := GPGL10111.ACTNUMBR_8;
+
+            if AreAllSegmentNumbersEmpty(ACTNUMBR_1, ACTNUMBR_2, ACTNUMBR_3, ACTNUMBR_4, ACTNUMBR_5, ACTNUMBR_6, ACTNUMBR_7, ACTNUMBR_8) then
+                GetSegmentNumbersFromGPAccountIndex(GPGL10111.ACTINDX, ACTNUMBR_1, ACTNUMBR_2, ACTNUMBR_3, ACTNUMBR_4, ACTNUMBR_5, ACTNUMBR_6, ACTNUMBR_7, ACTNUMBR_8);
+
+            DimSetID := CreateDimSet(ACTNUMBR_1, ACTNUMBR_2, ACTNUMBR_3, ACTNUMBR_4, ACTNUMBR_5, ACTNUMBR_6, ACTNUMBR_7, ACTNUMBR_8);
+            StatisticalAccJournalLine.Validate("Dimension Set ID", DimSetID);
+            StatisticalAccJournalLine.Modify(true);
+        end;
+    end;
+
     procedure MigrateAccountDetails(GPAccount: Record "GP Account"; var GLAccDataMigrationFacade: Codeunit "GL Acc. Data Migration Facade")
+    begin
+        case GPAccount.AccountType of
+            1:
+                MigrateGLAccountDetailsImp(GPAccount, GLAccDataMigrationFacade);
+            2:
+                MigrateStatisticalAccountDetailsImp(GPAccount);
+        end;
+    end;
+    
+    local procedure MigrateGLAccountDetailsImp(GPAccount: Record "GP Account"; var GLAccDataMigrationFacade: Codeunit "GL Acc. Data Migration Facade")
     var
         HelperFunctions: Codeunit "Helper Functions";
         DataMigrationErrorLogging: Codeunit "Data Migration Error Logging";
@@ -232,36 +336,74 @@ codeunit 4017 "GP Account Migrator"
         GLAccDataMigrationFacade.ModifyGLAccount(true);
     end;
 
-    procedure GenerateGLTransactionBatches(GPAccount: Record "GP Account");
+    local procedure MigrateStatisticalAccountDetailsImp(GPAccount: Record "GP Account")
+    var
+        StatisticalAccount: Record "Statistical Account";
+        GeneralLedgerSetup: Record "General Ledger Setup";
+        DataMigrationErrorLogging: Codeunit "Data Migration Error Logging";
+        AccountNum: Code[20];
+    begin
+        AccountNum := CopyStr(GPAccount.AcctNum.Trim(), 1, MaxStrLen(StatisticalAccount."No."));
+
+        if StatisticalAccount.Get(AccountNum) then
+            exit;
+
+        DataMigrationErrorLogging.SetLastRecordUnderProcessing(Format(GPAccount.RecordId));
+
+        StatisticalAccount."No." := AccountNum;
+        StatisticalAccount.Name := CopyStr(GPAccount.Name, 1, MaxStrLen(StatisticalAccount.Name));
+
+        if GeneralLedgerSetup.Get() then begin
+            StatisticalAccount."Global Dimension 1 Code" := GeneralLedgerSetup."Global Dimension 1 Code";
+            StatisticalAccount."Global Dimension 2 Code" := GeneralLedgerSetup."Global Dimension 2 Code";
+        end;
+
+        StatisticalAccount.Insert(true);
+    end;
+
+    procedure GenerateGLTransactionBatches(GPAccount: Record "GP Account")
+    begin
+        case GPAccount.AccountType of
+            1:
+                GenerateGLAccountTransactionsImp(GPAccount);
+            2:
+                GenerateStatisticalAccountTransactionsImp(GPAccount);
+        end;
+    end;
+
+    local procedure GenerateGLAccountTransactionsImp(GPAccount: Record "GP Account")
     var
         GPGLTransactions: Record "GP GLTransactions";
         GenJournalLine: Record "Gen. Journal Line";
         GPFiscalPeriods: Record "GP Fiscal Periods";
+        GLAccount: Record "G/L Account";
         GPCompanyAdditionalSettings: Record "GP Company Additional Settings";
         DataMigrationFacadeHelper: Codeunit "Data Migration Facade Helper";
-        PostingGroupCode: Code[10];
+        DocumentNo: Code[10];
         DimSetID: Integer;
         InitialYear: Integer;
     begin
+        if not GLAccount.Get(GPAccount.AcctNum) then
+            exit;
+
         InitialYear := GPCompanyAdditionalSettings.GetInitialYear();
 
-        GPGLTransactions.Reset();
         GPGLTransactions.SetCurrentKey(YEAR1, PERIODID, ACTINDX);
-        GPGLTransactions.SetFilter(ACTINDX, '= %1', GPAccount.AcctIndex);
+        GPGLTransactions.SetRange(ACTINDX, GPAccount.AcctIndex);
 
         if InitialYear > 0 then
             GPGLTransactions.SetFilter(YEAR1, '>= %1', InitialYear);
 
         if GPGLTransactions.FindSet() then
             repeat
-                PostingGroupCode := PostingGroupCodeTxt + format(GPGLTransactions.YEAR1) + '-' + format(GPGLTransactions.PERIODID);
+                DocumentNo := PostingGroupCodeTxt + Format(GPGLTransactions.YEAR1) + '-' + Format(GPGLTransactions.PERIODID);
 
                 if GPFiscalPeriods.Get(GPGLTransactions.PERIODID, GPGLTransactions.YEAR1) then begin
-                    DataMigrationFacadeHelper.CreateGeneralJournalBatchIfNeeded(CopyStr(PostingGroupCode, 1, 10), '', '');
+                    DataMigrationFacadeHelper.CreateGeneralJournalBatchIfNeeded(CopyStr(DocumentNo, 1, 10), '', '');
                     DataMigrationFacadeHelper.CreateGeneralJournalLine(
                         GenJournalLine,
-                        PostingGroupCode,
-                        PostingGroupCode,
+                        DocumentNo,
+                        DocumentNo,
                         CopyStr(DescriptionTrxTxt, 1, 50),
                         GenJournalLine."Account Type"::"G/L Account",
                         CopyStr(GPAccount.AcctNum, 1, 20),
@@ -279,6 +421,62 @@ codeunit 4017 "GP Account Migrator"
             until GPGLTransactions.Next() = 0;
     end;
 
+    local procedure GenerateStatisticalAccountTransactionsImp(GPAccount: Record "GP Account")
+    var
+        GPGLTransactions: Record "GP GLTransactions";
+        GPCompanyAdditionalSettings: Record "GP Company Additional Settings";
+        GPFiscalPeriods: Record "GP Fiscal Periods";
+        StatisticalAccount: Record "Statistical Account";
+        StatisticalAccJournalBatch: Record "Statistical Acc. Journal Batch";
+        StatisticalAccJournalLine: Record "Statistical Acc. Journal Line";
+        StatisticalAccJournalLineCurrent: Record "Statistical Acc. Journal Line";
+        InitialYear: Integer;
+        DocumentNo: Code[10];
+        LineNum: Integer;
+        DimSetID: Integer;
+    begin
+        if not StatisticalAccount.Get(GPAccount.AcctNum) then
+            exit;
+
+        InitialYear := GPCompanyAdditionalSettings.GetInitialYear();
+
+        GPGLTransactions.SetCurrentKey(YEAR1, PERIODID, ACTINDX);
+        GPGLTransactions.SetRange(ACTINDX, GPAccount.AcctIndex);
+
+        if InitialYear > 0 then
+            GPGLTransactions.SetFilter(YEAR1, '>= %1', InitialYear);
+
+        if GPGLTransactions.FindSet() then
+            repeat
+                DocumentNo := PostingGroupCodeTxt + Format(GPGLTransactions.YEAR1) + '-' + Format(GPGLTransactions.PERIODID);
+                if GPFiscalPeriods.Get(GPGLTransactions.PERIODID, GPGLTransactions.YEAR1) then begin
+                    if not StatisticalAccJournalBatch.Get('', DocumentNo) then begin
+                        StatisticalAccJournalBatch.Validate(Name, DocumentNo);
+                        StatisticalAccJournalBatch.Insert(true);
+                    end;
+
+                    StatisticalAccJournalLineCurrent.SetRange("Journal Batch Name", StatisticalAccJournalBatch.Name);
+                    if StatisticalAccJournalLineCurrent.FindLast() then
+                        LineNum := StatisticalAccJournalLineCurrent."Line No." + 10000
+                    else
+                        LineNum := 10000;
+
+                    StatisticalAccJournalLine.Validate("Journal Batch Name", DocumentNo);
+                    StatisticalAccJournalLine.Validate("Line No.", LineNum);
+                    StatisticalAccJournalLine.Validate("Document No.", DocumentNo);
+                    StatisticalAccJournalLine.Validate(Description, CopyStr(DescriptionTrxTxt, 1, MaxStrLen(StatisticalAccJournalLine.Description)));
+                    StatisticalAccJournalLine.Validate("Statistical Account No.", CopyStr(GPAccount.AcctNum, 1, MaxStrLen(StatisticalAccJournalLine."Statistical Account No.")));
+                    StatisticalAccJournalLine.Validate("Posting Date", GPFiscalPeriods.PERIODDT);
+                    StatisticalAccJournalLine.Validate(Amount, GPGLTransactions.PERDBLNC);
+                    StatisticalAccJournalLine.Insert();
+
+                    DimSetID := CreateDimSet(GPGLTransactions.ACTNUMBR_1, GPGLTransactions.ACTNUMBR_2, GPGLTransactions.ACTNUMBR_3, GPGLTransactions.ACTNUMBR_4, GPGLTransactions.ACTNUMBR_5, GPGLTransactions.ACTNUMBR_6, GPGLTransactions.ACTNUMBR_7, GPGLTransactions.ACTNUMBR_8);
+                    StatisticalAccJournalLine.Validate("Dimension Set ID", DimSetID);
+                    StatisticalAccJournalLine.Modify(true);
+                end;
+            until GPGLTransactions.Next() = 0;
+    end;
+
     local procedure CreateDimSet(ACTNUMBR_1: Code[20]; ACTNUMBR_2: Code[20]; ACTNUMBR_3: Code[20]; ACTNUMBR_4: Code[20]; ACTNUMBR_5: Code[20]; ACTNUMBR_6: Code[20]; ACTNUMBR_7: Code[20]; ACTNUMBR_8: Code[20]): Integer
     var
         TempDimensionSetEntry: Record "Dimension Set Entry" temporary;

Apps/W1/HybridGP/app/src/Migration/GPTables/GPGL00100.Table.al

@@ -56,8 +56,9 @@ codeunit 40125 "GP Populate Combined Tables"
         GPAccount: Record "GP Account";
         AccountDescription: Text;
     begin
-        GPGL00100.SetRange(ACCTTYPE, 1);
-        // Only want to bring in Posting Accounts, no unit accounts allowed
+        GPGL00100.SetFilter(ACCTTYPE, '1|2');
+        // Only Posting and Unit accounts
+
         if not GPGL00100.FindSet() then
             exit;
 
@@ -73,7 +74,7 @@ codeunit 40125 "GP Populate Combined Tables"
             if AccountDescription = '' then
                 AccountDescription := GPGL00100.ACTDESCR;
 
-            CLEAR(GPAccount);
+            Clear(GPAccount);
 #pragma warning disable AA0139
             GPAccount.AcctNum := GPGL00100.MNACSGMT.Trim();
 #pragma warning restore AA0139
@@ -138,7 +139,6 @@ codeunit 40125 "GP Populate Combined Tables"
         CurrentKey := 1;
         GPGL10110.SetFilter(PERDBLNC, '<>0');
         GPGL10110.SetFilter(PERIODID, '>0');
-        GPGL10110.SetRange(GL00100ACCTYPE1Exist, true);
         GPGL10110.SetCurrentKey(YEAR1, PERIODID, ACTNUMBR_1, ACTNUMBR_2, ACTNUMBR_3, ACTNUMBR_4, ACTNUMBR_5, ACTNUMBR_6, ACTNUMBR_7, ACTNUMBR_8);
         if GPGL10110.FindSet() then
             repeat
@@ -201,7 +201,6 @@ codeunit 40125 "GP Populate Combined Tables"
 
         GPGL10111.SetFilter(PERDBLNC, '<>0');
         GPGL10111.SetFilter(PERIODID, '>0');
-        GPGL10111.SetRange(GL00100ACCTYPE1Exist, true);
         GPGL10111.SetCurrentKey(YEAR1, PERIODID, ACTNUMBR_1, ACTNUMBR_2, ACTNUMBR_3, ACTNUMBR_4, ACTNUMBR_5, ACTNUMBR_6, ACTNUMBR_7, ACTNUMBR_8);
         if GPGL10111.FindSet() then
             repeat