Skip to content

Commit 57a627f

Browse files
Correct filtering by using SetRange instead of SetFilter. (#26535)
This change corrects filtering for some of the history pages. Filters were broken for Customers/Vendors that had an & symbol in their No. field. Fixes #26487 Fixes [AB#537204](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/537204) Co-authored-by: jaymckinney <[email protected]>
1 parent 196f5b9 commit 57a627f

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

Apps/W1/DynamicsGPHistoricalData/app/src/Pages/HistPayablesDocuments.Page.al

+2-2
Original file line numberDiff line numberDiff line change
@@ -187,10 +187,10 @@ page 41017 "Hist. Payables Documents"
187187
trigger OnOpenPage()
188188
begin
189189
if FilterAuditCode <> '' then
190-
Rec.SetFilter("Audit Code", FilterAuditCode);
190+
Rec.SetRange("Audit Code", FilterAuditCode);
191191

192192
if FilterVendorNo <> '' then
193-
Rec.SetFilter("Vendor No.", FilterVendorNo);
193+
Rec.SetRange("Vendor No.", FilterVendorNo);
194194
end;
195195

196196
procedure SetFilterAuditCode(AuditCode: Code[35])

Apps/W1/DynamicsGPHistoricalData/app/src/Pages/HistPurchaseRecvHeaders.Page.al

+1-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ page 41014 "Hist. Purchase Recv. Headers"
172172
trigger OnOpenPage()
173173
begin
174174
if FilterVendorNo <> '' then
175-
Rec.SetFilter("Vendor No.", FilterVendorNo);
175+
Rec.SetRange("Vendor No.", FilterVendorNo);
176176
end;
177177

178178
procedure SetFilterVendorNo(VendorNo: Code[35])

Apps/W1/DynamicsGPHistoricalData/app/src/Pages/HistReceivablesDocuments.Page.al

+1-1
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ page 41016 "Hist. Receivables Documents"
177177
trigger OnOpenPage()
178178
begin
179179
if FilterCustomerNo <> '' then
180-
Rec.SetFilter("Customer No.", FilterCustomerNo);
180+
Rec.SetRange("Customer No.", FilterCustomerNo);
181181
end;
182182

183183
procedure SetFilterCustomerNo(CustomerNo: Code[35])

Apps/W1/DynamicsGPHistoricalData/app/src/Pages/HistSalesTrxHeaders.Page.al

+1-1
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ page 41002 "Hist. Sales Trx. Headers"
187187
trigger OnOpenPage()
188188
begin
189189
if FilterCustomerNo <> '' then
190-
Rec.SetFilter("Customer No.", FilterCustomerNo);
190+
Rec.SetRange("Customer No.", FilterCustomerNo);
191191
end;
192192

193193
procedure SetFilterCustomerNo(CustomerNo: Code[35])

0 commit comments

Comments
 (0)