python-stdlib/tarfile: Fixed permissions when adding to archive. #799
Conversation
|
I changed the value from |
| @@ -63,7 +64,7 @@ def skip(self): | |||
| class TarInfo: | |||
| def __init__(self, name=""): | |||
| self.name = name | |||
| self.mode = _S_IFDIR if self.name[-1] == "/" else _S_IFREG | |||
| self.mode = _S_IFDIR if os.stat(name)[0] == 0x4000 else _S_IFREG | |||
There was a problem hiding this comment.
What happens if name doesn't exist on disk? In the case that you are extracting from a tar file, the files most likely do not exist on disk, so this will now raise an exception because the file isn't found.
There was a problem hiding this comment.
thank you @dpgeorge
I didn't think of that at all 🤔
would you be ok if I added a try/except condition?
I like the flexibility offered by not having to rely on what the user hands in.
In my code I always test if the fs item exists, but I neglected to do it in this case
There was a problem hiding this comment.
I dug deeper and probably have to handle archive and expand in two different ways.
During expansion it does need to rely on the name coming from the item in the archive 🤔
There was a problem hiding this comment.
@dpgeorge @projectgus
please take a look at my last commit, I think I found a compromise 😄
| @@ -1,6 +1,7 @@ | |||
| """Subset of cpython tarfile class methods needed to decode tar files.""" | |||
|
|
|||
| import uctypes | |||
| import os | |||
There was a problem hiding this comment.
This import shouldn't be needed anymore.
There was a problem hiding this comment.
true!
fixing it now
There was a problem hiding this comment.
done!
I really appreciate your time, @dpgeorge 🙏🏼
Signed-off-by: ubi de feo <[email protected]>
dpgeorge
force-pushed
the
bugfix/tarfile-write-permissions
branch
from
9b64934 to
8058b29
Compare
|
Thanks for updating. Rebased and merged. |
This change fixes issue #797 which I opened a couple of days ago.
More context to be found there.
This is my first PR in which I tried to be neater, hope it'll get reviewed by someone :)
thanks
ubi