-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade braces #2
base: master
Are you sure you want to change the base?
Conversation
@jonschlinkert It looks like in a braces version between 0.1.4 and 2.3.1 the handling of one braces value has been changed. I am not too familiar with what Could you please take a look at this and give some feedback. Thanks |
@jonschlinkert the cases failed mostly for brace with single item changes
|
Thank you for the PR @mobilutz! If it's not too much trouble, could you update the (edit: and I will take care of fixing the tests) |
@Teamop I didn't read your last message, it was deleted. Please create a new issue as I requested in my last comment. Also, if the unit tests are failing, it's because the unit tests are wrong in this library. Braces is correct per specification, and there are comprehensive unit tests as such. If you see something that is wrong in braces, and you can point to the specification that shows that the behavior is wrong, then please create an issue on braces. |
@jonschlinkert ok, not sure why it was deleted... thanks again |
@jonschlinkert ohh.. I just saw the recent message, so the test cases are wrong, that's the reason why the cases failed. I'm not familiar with braces expansion, so thanks for your explanation. |
@jonschlinkert I updated Now node 0.10 and 0.12 are failing completely because of mocha - the version 5.2.0 of mocha requires node >4: https://github.com/mochajs/mocha/blob/v5.2.0/package.json#L452 |
@jonschlinkert I downgrade mocha to the same version of braces, and now all travis runs fail at the same points. |
You should be able to upgrade the lock file and mocha. Tests will fail, I’ll fix the tests.
…Sent from my iPhone
On Feb 19, 2019, at 4:23 AM, Lutz Lengemann ***@***.***> wrote:
@jonschlinkert I downgrade mocha to the same version of braces, and now all travis runs fail at the same points.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@gregorycraske You can use yarns We have this in our package.json
Of course and upgrade hear would be better, but with this you can have a correct audit and secure system. |
Any update with the travis tests? |
@jonschlinkert I am cleaning up all my old GitHub PullRequests and want to ask how I can support further here. I currently cannot find the TravisCI runs at all, and don't know how I can push this change forward. |
https://www.npmjs.com/advisories/786