Tests: improve coverage #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this PR due to no activity. Feel free to reopen. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bratelefant
approved these changes
Jul 23, 2024
| } | ||
|
|
||
| if (!newPassword) { | ||
| return callback(new Error('Password may not be empty')); | ||
| } | ||
|
|
||
| call( | ||
| 'changePassword', | ||
| oldPassword ? hashPassword(oldPassword) : null, | ||
| hashPassword(newPassword), |
There was a problem hiding this comment.
Is it really hashed here? Had a look at Meteors password_server.js, looks like the newPassword is hashed on the server side
There was a problem hiding this comment.
Ok got it, it sending the object with the sha256 hash, not the string.
| @@ -90,8 +98,16 @@ class AccountsPassword { | |||
| * @param callback {function(e:Error)=} optional callback that is invoked with one optional error argument | |||
| */ | |||
| resetPassword = (token, newPassword, callback = () => {}) => { | |||
| if (!(typeof token === 'string' || token instanceof String)) { | |||
There was a problem hiding this comment.
Why is the type checking different from e.g the createUser function here?
There was a problem hiding this comment.
General question on the restoreAll function; can't we simply do sinon.restore() here?
|
Closing this PR due to no activity. Feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
in order to make big changes/improvements/fixes without regression we need better test coverage ☔
By writing the tests there were mutliple issues that have been detected and commented accordingly, they are attempted to be non-breaking. Please consider once you review the PR.
Also note this PR is draft-mode until we reach >= 90% coverage!
Linked issue(s)
#152
Involved parts of the project
all
Added tests?
a lot
Targeted Meteor release version
2.x yet
Reproduction
run tests