Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Improve primitive and reference types utilities #356

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -8,6 +8,9 @@ and this project adheres to

## [Unreleased][unreleased]

- Add primitive type: bigint for isScalar
- Implement isReference

## [2.2.0][] - 2020-07-10

### Added
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -53,6 +53,7 @@ $ npm install @metarhia/common
- [id](#idx)
- [asyncId](#asyncidx-callback)
- [isScalar](#isscalarvalue)
- [isReference](#isreferencevalue)
- [copy](#copyds)
- [clone](#cloneobj)
- [duplicate](#duplicateobj)
@@ -576,6 +577,14 @@ _Returns:_ [`<boolean>`][boolean]

Check if value is scalar

### isReference(value)

- `value`: `<any>`

_Returns:_ [`<boolean>`][boolean]

Check if value is reference

### copy(ds)

- `ds`: [`<Object[]>`][object] source dataset to be copied
9 changes: 8 additions & 1 deletion lib/data.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
'use strict';

const SCALAR_TYPES = ['boolean', 'number', 'string', 'undefined'];
const SCALAR_TYPES = ['boolean', 'number', 'string', 'undefined', 'bigint'];
const REF_TYPES = ['object', 'function'];

// Check if value is scalar
// value - <any>
// Returns: <boolean>
const isScalar = value => SCALAR_TYPES.includes(typeof value);

// Check if value is reference
// value - <any>
// Returns: <boolean>
const isReference = value => value !== null && REF_TYPES.includes(typeof value);

// Copy dataset (copy objects to new array)
// ds - <Object[]>, source dataset to be copied
// Returns: <Object[]>
@@ -175,6 +181,7 @@ const mergeObjects = (merger, ...objs) => {

module.exports = {
isScalar,
isReference,
copy,
clone,
duplicate,
12 changes: 12 additions & 0 deletions test/data.js
Original file line number Diff line number Diff line change
@@ -11,6 +11,10 @@ metatests.case(
{
'common.isScalar': [
[0, true],
[1, true],
[1.5, true],
[1n, true],
[-1n, true],
['value1', true],
[50, true],
[true, true],
@@ -23,6 +27,14 @@ metatests.case(
[{}, false],
['', true],
],
'common.isReference': [
[{}, true],
[[], true],
[() => {}, true],
[1n, false],
[null, false],
[undefined, false],
],
'common.copy': [
[
[1, 2, 3],